ci: Fix broken Jira search block PR merges - #1872
Open
isivaselvan wants to merge 2 commits into
Open
Conversation
tomhjp/gh-action-jira-search still calls the deprecated Jira /rest/api/3/search endpoint, which Atlassian has removed (returns HTTP 410, migrate to /rest/api/3/search/jql). Same failure and same root cause as hashicorp/terraform-provider-kubernetes#2958 - upstream shows no sign of fixing this (no newer tag/commit addresses the endpoint, no open issue/PR). Mark the Search step continue-on-error so this internal Jira-sync housekeeping stops blocking mergeStateStatus on every PR event other than "opened". Downstream steps already gate on steps.search.outputs.issue, so they skip cleanly rather than error when Search fails without setting it. Note: because this workflow triggers on pull_request_target, GitHub always executes the workflow file from the base branch (main), never from the PR's head branch - this is deliberate security hardening so fork PRs can't rewrite a workflow that has secret access. That means this fix cannot make its own PR's "Jira sync" check pass; it only takes effect for PRs opened/edited after this merges into main. Verified the continue-on-error + downstream-skip mechanism locally via actionlint and a synthetic `act` repro (same verification already done for the identical fix in terraform-provider-kubernetes#2958).
No release-note block - this is a CI-only workflow change with no user-facing effect on the provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, revert this commit - it only changes CI workflow behavior, nothing in the provider binary.
Changes to Security Controls
None. This is a CI-only workflow change; no provider code, schema, or runtime behavior is affected.
Description
The
Jira synccheck (.github/workflows/jira-pr.yml) fails on every PR event other thanopened(edits, closes, reopens). Root cause: theSearchstep callstomhjp/gh-action-jira-search, whosemain.gohardcodes a call to Jira'sGET /rest/api/3/searchendpoint — an endpoint Atlassian has since retired:Since this workflow is internal Jira-ticket bookkeeping with no bearing on code correctness, this PR marks the
Searchstepcontinue-on-error: trueso it stops blockingmergeStateStatuson unrelated PRs while upstream remains unfixed. The downstream steps (Sync comment,Close PR,Reopen PR) already gate onsteps.search.outputs.issue, so whenSearchfails without setting that output, they skip cleanly instead of the job erroring.Same fix, same root cause, already applied to the sibling
terraform-provider-kubernetesrepo: hashicorp/terraform-provider-kubernetes#2958.Scope note:
.github/workflows/jira-issues.ymlhas the identical pattern and will fail the same way, but is intentionally left out of this PR to keep the change scoped to what's actually blocking PR merges — same scoping decision made in the companion k8s-provider fix.Acceptance tests
Not applicable — this is a GitHub Actions workflow change, not provider code, so
make testaccdoesn't apply. Verified instead via:Release Note
Release note for CHANGELOG:
References
/rest/api/3/search/rest/api/3/searchremoved, migrate to/rest/api/3/search/jqlCommunity Note