Skip to content

fix: remove unsafe exec() in Gamelink.cpp#4

Open
orbisai0security wants to merge 1 commit into
hasseily:masterfrom
orbisai0security:fix-gamelink-memcpy-buffer-overflow
Open

fix: remove unsafe exec() in Gamelink.cpp#4
orbisai0security wants to merge 1 commit into
hasseily:masterfrom
orbisai0security:fix-gamelink-memcpy-buffer-overflow

Conversation

@orbisai0security

Copy link
Copy Markdown

Summary

Fix critical severity security issue in NoxArchaistCompanion/RemoteControl/Gamelink.cpp.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File NoxArchaistCompanion/RemoteControl/Gamelink.cpp:162

Description: Three memcpy calls in Gamelink.cpp copy attacker-influenced data into fixed-size shared memory buffers without verifying that the source size fits within the destination. At line 162, truncated.size() is used as the copy length into g_p_shared_memory->program. At lines 266 and 319, a caller-supplied 'payload' value is used directly as the copy length without any upper-bound validation. If any of these sizes exceed the destination buffer's allocated size, adjacent heap or shared memory regions are overwritten, corrupting control flow data and potentially enabling arbitrary code execution.

Changes

  • NoxArchaistCompanion/RemoteControl/Gamelink.cpp

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant