Systemic API Standardization & Interceptor Hardening#437
Open
ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
Open
Systemic API Standardization & Interceptor Hardening#437ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
Conversation
This commit patches the admin_endpoints validation to gracefully handle empty POST bodies, and modifies MessageMiddleware to intercept MontageErrors so they correctly return 400 Bad Request JSON instead of bypassing CORS headers. Resolves Issue hatnote#357.
Bind :disabled='isLoading' on vote buttons to block concurrent clicks at DOM level before Vue's async re-render cycle can prevent them.
…atnote#325) getRoundVotesStats was defined in jurorService but never called. Added onMounted fetch and post-vote refresh in VoteRating.vue and VoteYesNo.vue, with conditional rendering when round.show_stats is true.
Author
|
I am closing this PR to reduce repository noise. The core fixes relevant to my GSoC Proposal are being manually consolidated into PR #454 and PR #415 to make it substantially easier for the maintainers to review my code. The larger concepts discussed here will be implemented incrementally and manually if my proposal is accepted. |
Author
|
I have stripped the AI formatting from the description and reopened this PR so I can manually improve its code over the coming days, fulfilling my promise. |
Author
|
Closing this conceptual proposal. Consolidating my Open Source footprint to prioritize high-value, locally verified bug fixes for the current review window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSoC 2026 Blueprint — Phase 1: Systemic API Standardization & Interceptor Hardening
Problem
The Montage API currently returns inconsistent response shapes across endpoints. Some return
{status, data}, others return raw objects, and error states are non-uniform — causing the Vue frontend to defensively null-check every response and making it impossible to write reliable Axios interceptors.Specific failure modes observed during pre-application audit:
MontageErrorexceptions bypass CORS middleware (fixed in PR Fixes #357 by serializing MontageErrors natively in MessageMiddleware and hardening the round_creation API contract. #415, but root cause is the missing standard envelope)alertService.jscannot distinguish between astatus: failureand a network-level 5xxProposed Architecture
Standardize all API responses to a single envelope schema:
sequenceDiagram participant Vue as Vue Component participant Axios as Axios Interceptor participant MW as MessageMiddleware participant DAO as DAO Layer participant DB as Database Vue->>Axios: Any API request Axios->>MW: Forwards with auth headers MW->>DAO: Validated request alt Success path DAO->>DB: Query DB-->>DAO: Result DAO-->>MW: Data MW-->>Axios: {status: "ok", data: {...}} else Error path DAO-->>MW: raises MontageError MW-->>Axios: {status: "failure", errors: [...]} end Axios->>Axios: Interceptor reads status field Axios-->>Vue: Resolved or rejected PromiseStandard Envelope Schema (Target)
{ "status": "ok | failure | exception", "data": { ... }, "errors": ["human-readable error strings"], "meta": { "request_id": "...", "timestamp": "..." } }GSoC Deliverable Mapping