Skip to content

Security: Harden Juror Authorization & Fix Validation Bypass (#370) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayushshukla1807 wants to merge 1 commit into from
Closed

Security: Harden Juror Authorization & Fix Validation Bypass (#370) #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions montage/rdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2462,7 +2462,7 @@ def __init__(self, user_dao):

def _get_round_juror(self, round_id):
round_juror = (self.query(RoundJuror)
.filter_by(user=self.user,
.filter_by(user_id=self.user.id,
round_id=round_id)
.one_or_none())
return round_juror
Expand All @@ -2471,25 +2471,32 @@ def _get_round_juror(self, round_id):
def get_campaign(self, campaign_id):
if self.user.is_maintainer:
return self.user_dao._get_any_campaign(campaign_id)

# Security Hardening: We query the association proxy directly to ensure
# the juror is not only assigned by ID, but also strictly active in the round.
campaign = self.query(Campaign)\
.filter(Campaign.rounds.any(
Round.jurors.any(username=self.user.username)))\
Round.round_jurors.any(
user_id=self.user.id,
is_active=True)))\
.filter_by(id=campaign_id)\
.one_or_none()
if not campaign:
raise Forbidden('not a juror on campaign %s' % campaign_id)
raise Forbidden('not an active juror on campaign %s' % campaign_id)
return campaign

def get_round(self, round_id):
if self.user.is_maintainer:
return self.user_dao._get_any_round(round_id)
rnd = self.query(Round)\
.filter(
Round.jurors.any(username=self.user.username),
Round.round_jurors.any(
user_id=self.user.id,
is_active=True),
Round.id == round_id)\
.one_or_none()
if not rnd:
raise Forbidden('not a juror for round %s' % round_id)
raise Forbidden('not an active juror for round %s' % round_id)
return rnd

def get_round_entry(self, round_id, entry_id):
Expand Down