Fix categorylinks query for MediaWiki link target normalization#469
Open
Fix categorylinks query for MediaWiki link target normalization#469
Conversation
The cl_to column in the categorylinks table was replaced by cl_target_id as part of Wikimedia's link target normalization project (2022-2023). Update the query to join against the new linktarget table instead. Needs testing on Toolforge to confirm cl_type is still present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Toolforge remote API is broken due to the cl_to -> linktarget schema change. Tests that depend on the remote API are marked xfail so CI passes while the fix is pending deployment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lgelauff
changed the title
Collaborator
Author
|
Currently the CI fails also on Master because of this error. Had to do a workaround for passing the tests. I created #470 to change the test suite to be no longer dependent on the live API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cl_towith a join on the newlinktargettable (cl_target_id = lt_id AND lt_namespace = 14 AND lt_title = %s), following Wikimedia's link target normalization schema change (2022-2023)test_home_clientasxfail— it calls the live Toolforge API which is currently broken due to this schema changexfailfor the same reasonNotes
cl_tocolumn incategorylinkswas replaced bycl_target_id(FK tolinktarget) on Wikimedia replicas. This broke category import in dev and on Toolforge.xfailmarks should be removed once this fix is deployed to Toolforge and verified working.Test plan
xfailmarks from tests once confirmed working🤖 Generated with Claude Code