Update download-hz-dist to support multiple repositories [DI-730]#67
Update download-hz-dist to support multiple repositories [DI-730]#67JackPGreen wants to merge 3 commits into
download-hz-dist to support multiple repositories [DI-730]#67Conversation
JackPGreen
force-pushed
the
DI-730
branch
11 times, most recently
from
9d6ff64 to
643b865
Compare
JackPGreen
changed the title
download-hz-dist to support multiple repositories
JackPGreen
changed the title
download-hz-dist to support multiple repositoriesdownload-hz-dist to support multiple repositories [DI-730]
JackPGreen
changed the title
download-hz-dist to support multiple repositories [DI-730]download-hz-dist to support multiple repositories [DI-730]
| echo "url=${url}" >> ${GITHUB_OUTPUT} | ||
| exit 0 | ||
| else | ||
| echodebug "Failed to download from ${url}" |
There was a problem hiding this comment.
not a failure but just not found.
otherwise little misleading!
There was a problem hiding this comment.
Well it could be a failure... all it really means is curl returned a non-0 exit code. But you won't be able to see that, because --silent...
| fi | ||
| done <<< "${{ steps.derive-repositories.outputs.repositories }}" | ||
|
|
||
| echoerr "Distribution not found in ${{ steps.derive-repositories.outputs.repositories }}" |
There was a problem hiding this comment.
| echoerr "Distribution not found in ${{ steps.derive-repositories.outputs.repositories }}" | |
| echoerr "Distribution '${{ steps.derive-output-file.outputs.file }}' not found in ${{ steps.derive-repositories.outputs.repositories }}" |
There was a problem hiding this comment.
That's not accurate as that's a user input (i.e. they could set the output file to anything). You could set it to inputs.distribution, but then you'd want to see the version etc and it just gets confusing.
| case "${ENVIRONMENT}" in | ||
| live) | ||
| repos=$(cat <<'EOF' | ||
| https://repo.maven.apache.org/maven2 |
There was a problem hiding this comment.
not sure here but can we say whats the more frequent use case i.e. snapshots or release?
the list should favor that to minimize curl misses
we also do more PATCH releases so may be central should be last
not a big deal but thought I mention
There was a problem hiding this comment.
It's ordered alphabetically. I don't know what ordering would be more efficient, I did think about doing it in parallel but if more than one was successful (i.e. preprod + live) it'd overwrite the same file and be a mess so just left it.
| ;; | ||
| *) | ||
| echoerr "Unsupported platform behaviour for ${base_image_name}" ; return 1 | ||
| echoerr "Unsupported platform behaviour for ${base_image_name}" ; exit 1 |
There was a problem hiding this comment.
You return from a function, and exit from a shell - it's not in a function, so we shouldn't return.
I copied this switch when adding the repo switch statement to the new action and spotted it so thought I'd fix it there too.
Co-Authored-By: Nishaat Rajabali <12186256+nishaatr@users.noreply.github.com>
|
2 participants
As part of the groundwork to support DI-730, improve
download-hz-dist:SNAPSHOT/OSS/EE etc)hazelcast-dockerandhazelcast-packagingis duplicated in each GitHub repo environmentmaven-dependency-pluginmvnwithcurl