Skip to content

Add multiple union catalogue ids #2365#2366

Merged
TobiasNx merged 18 commits into
masterfrom
2365-verbundkatalogIds
Jun 24, 2026
Merged

Add multiple union catalogue ids #2365#2366
TobiasNx merged 18 commits into
masterfrom
2365-verbundkatalogIds

Conversation

@TobiasNx

@TobiasNx TobiasNx commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding k10PlusId, hebisId, bsbId, kobvId, gbvId, bszId, and obvId

All except gbvId and bszId also include links into the catalogues.

Related to #2365

TobiasNx added 10 commits June 17, 2026 11:42
@TobiasNx
Add k10PlusId #2365
f637f48 
Regex from wikidata: https://www.wikidata.org/wiki/Property:P6721
@TobiasNx
Add b3katId #2365
b02cd32 
Regex Pattern from https://www.wikidata.org/wiki/Wikidata:Property_proposal/B3Kat_Joint_Union_Catalogue
@TobiasNx
Add test 99374153235806441 for hebsId #2326
a16de7b
@TobiasNx
Sort context.jsonld correctly
f5cf2b7 
Classes first then properties. Both alphabetically.
@TobiasNx
Add hebisId #2365
73be4ed
@TobiasNx
Add test 990183146600206441 for OBV #2326
ba22eb8
@TobiasNx
Add obvId #2365
4e35b6b
@TobiasNx
Add regex pattern for union catalogue id #2365
20ddeab 
From:

k10plus: https://www.wikidata.org/wiki/Property:P6721
B3Kat: https://www.wikidata.org/wiki/Wikidata:Property_proposal/B3Kat_Joint_Union_Catalogue
hebis : https://www.hebis.de/pica-kategorie/0100/
OBV: https://www.wikidata.org/wiki/Property:P6201
@TobiasNx
Update web tests #2365
72f40f6
@TobiasNx
Add additional regex for hbzId and dnbId
c832a12
@TobiasNx TobiasNx changed the title Add multiple union catalogue ids Add multiple union catalogue ids #2365 Jun 17, 2026
@TobiasNx TobiasNx requested a review from acka47 June 17, 2026 12:44
acka47
acka47 requested changes Jun 23, 2026
View reviewed changes

@acka47 acka47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this wrt the additions to the lobid data and its internal consistence. Some things have to be fixed and some removed. Note that I did not check whether the different IDs are correctly sourced from the MARC data.

Comment thread src/test/resources/alma-fix/99371874404306441.json
"deprecatedUri" : "http://lobid.org/resources/HT021692747#!",
"isbn" : [ "0028653238", "9780028653235" ],
"oclcNumber" : [ "163175852" ],
"kobvId" : "gbv_33764683X",

@acka47 acka47 Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird. Does KOBV really base their internal IDs on GBV IDs?

@TobiasNx TobiasNx Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is correct: https://portal.kobv.de/uid.do?query=gbv_33764683X&index=internal&plv=2

The UIDs almafu_BV008474744` are from the source systems.

There are also https://portal.kobv.de/uid.do?query=almafu_BV008474744&index=internal&plv=2

Comment thread src/test/resources/alma-fix/990363946050206441.json Outdated
"id" : "https://hub.culturegraph.org/resource/(DE-605)990363946050206441",
"label" : "Culturegraph-Ressource"
}, {
"id" : "https://opac.k10plus.de/DB=2.299/PPNSET?PPN=01281704X&PRS=HOL&INDEXSET=21",

@acka47 acka47 Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we should also add sameAs links besides the ID. Also, this specific link says "Titel nicht in datenbank vorhanden" when opening it in the browser.

Another thing is that the URL rather identifies the record not the resource and as far as I can tell until now we made sure to put URIs of the bibliographic resource into sameAs.

I suggest leaving sameAs out (for now).

Comment thread web/conf/context.jsonld Outdated
Comment thread web/conf/context.jsonld Outdated
Comment thread web/conf/context.jsonld Outdated
Comment thread web/conf/context.jsonld Outdated
Comment thread web/conf/context.jsonld Outdated
Comment thread web/conf/context.jsonld Outdated
Comment thread src/main/resources/alma/fix/relatedRessourcesAndLinks.fix Outdated
add_field("sameAs[].$last.label","DNB-Ressource")
end

# bvb

@acka47 acka47 Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in another comment, we should leave out sameAs for now.

Comment thread src/test/resources/alma-fix/99371874404306441.json Outdated
Comment on lines 150 to 155
"id" : "https://opac.k10plus.de/DB=2.299/PPNSET?PPN=gbv_33764683X&PRS=HOL&INDEXSET=21",
"label" : "K10plus-Ressource"
}, {
"id" : "https://opac.k10plus.de/DB=2.299/PPNSET?PPN=33764683X&PRS=HOL&INDEXSET=21",
"label" : "K10plus-Ressource"
} ],

@acka47 acka47 Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are somewhat redundant and one of the links isn't working. However, as stated elsewhere, we should not add sameAs for now anyway.

@TobiasNx TobiasNx Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been an error with regard to the mapping pattern. But since I deleted all sameAs we can ignore this.

@acka47 acka47 assigned TobiasNx and unassigned acka47 Jun 23, 2026
@TobiasNx TobiasNx force-pushed the 2365-verbundkatalogIds branch from 396d9bf to 78673b7 Compare June 23, 2026 10:36
@TobiasNx TobiasNx force-pushed the 2365-verbundkatalogIds branch from 72b356f to 590dbed Compare June 23, 2026 15:13
@TobiasNx @acka47
Change ID to id #2365
07896bd 
As suggested by reviewer

Co-authored-by: Adrian Pohl <acka47@users.noreply.github.com>
@TobiasNx TobiasNx assigned acka47 and unassigned TobiasNx Jun 24, 2026
@TobiasNx TobiasNx linked an issue Jun 24, 2026 that may be closed by this pull request
Add other Verbund-Ids #2365
Open
acka47
acka47 approved these changes Jun 24, 2026
View reviewed changes

@acka47 acka47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 assigned TobiasNx and unassigned acka47 Jun 24, 2026
@TobiasNx TobiasNx merged commit c00f6ec into master Jun 24, 2026
1 check passed
@TobiasNx TobiasNx deleted the 2365-verbundkatalogIds branch June 24, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acka47 acka47 acka47 approved these changes

Assignees

@TobiasNx TobiasNx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add other Verbund-Ids

2 participants

@TobiasNx @acka47