Skip to content

Show holdings also for eResources and resources with superordination #1865#2373

Open
TobiasNx wants to merge 1 commit into
masterfrom
1865-guiHoldings
Open

Show holdings also for eResources and resources with superordination #1865#2373
TobiasNx wants to merge 1 commit into
masterfrom
1865-guiHoldings

Conversation

@TobiasNx

@TobiasNx TobiasNx commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Resolves #1865

This often helps with debugging, since it shows that there are items connected to the records.

In order to highlight the Free link, we could Improve the GUI label from "Freie Online-Ressource:"

http://lobid.org/resources/990134555090206441

Without the change:
grafik

With the change of this PR:
http://quaoar13.hbz-nrw.de:7508/resources/990134555090206441
grafik

http://lobid.org/resources/990368617770206441

Without the change:
grafik

With the change of this PR:

http://quaoar13.hbz-nrw.de:7508/resources/990368617770206441
grafik

@TobiasNx TobiasNx changed the title Show holdings also for eResources and supevolumes #1865 Show holdings also for eResources and resources with superordination #1865 Jun 26, 2026
@TobiasNx TobiasNx requested a review from acka47 June 26, 2026 12:34
@acka47

acka47 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Regarding the process, the code review should rather be done by @dr0i and I can do functional review if you deploy it to staging.

@acka47 acka47 removed their request for review June 29, 2026 08:38
@acka47 acka47 removed their assignment Jun 29, 2026
@TobiasNx

TobiasNx commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@acka47 you were intended for the functional review:

it is on staging: http://quaoar13.hbz-nrw.de:7508/resources/990134555090206441 and http://quaoar13.hbz-nrw.de:7508/resources/990368617770206441

Was already included in the initial post, I messed up one of the links above, fixed it.

not sure if @dr0i or @fsteeg should review the webapp changes.

@acka47

acka47 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

it is on staging: http://quaoar13.hbz-nrw.de:7508/resources/990134555090206441 and http://quaoar13.hbz-nrw.de:7508/resources/990368617770206441

I get for both links: "Ein Titel mit der ID xy konnte nicht gefunden werden."

@TobiasNx

Copy link
Copy Markdown
Contributor Author

it is on staging: http://quaoar13.hbz-nrw.de:7508/resources/990134555090206441 and http://quaoar13.hbz-nrw.de:7508/resources/990368617770206441

I get for both links: "Ein Titel mit der ID xy konnte nicht gefunden werden."

Damn, sorry for this. @dr0i deployed it on test on friday, maybe this was overwritten, or because of the small index is not included. Will get back to you, when this is fixed

@dr0i

dr0i commented Jun 29, 2026

Copy link
Copy Markdown
Member

Deployed on test now: http://quaoar13.hbz-nrw.de:7508/resources/990134555090206441 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add holdings to GUI of publications that are electronical or are supervolumnes

3 participants