Skip to content

Add new verbund ids to index #2365#2375

Merged
dr0i merged 1 commit into
masterfrom
2365-indexVerbundIds
Jun 29, 2026
Merged

Add new verbund ids to index #2365#2375
dr0i merged 1 commit into
masterfrom
2365-indexVerbundIds

Conversation

@TobiasNx

Copy link
Copy Markdown
Contributor

@dr0i we need these ids for hbz/schlagwortfolgen-harvester#1
hebisId was already indexed, since it was introduced by @fsteeg in context of rpb.

@acka47 acka47 changed the title Add add new verbund ids #2365 Add add new verbund ids to index #2365 Jun 29, 2026
@acka47 acka47 changed the title Add add new verbund ids to index #2365 Add new verbund ids to index #2365 Jun 29, 2026
@TobiasNx TobiasNx requested a review from dr0i June 29, 2026 12:37
@TobiasNx TobiasNx force-pushed the 2365-indexVerbundIds branch from ced15fe to 1a11a01 Compare June 29, 2026 12:41

@dr0i dr0i left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd to me, see why e.g. at https://stackoverflow.com/questions/52845088/difference-between-keyword-and-text-in-elasticsearch ("text" vs "keyword"). I mean "id" feels like "keyword".

@dr0i dr0i assigned TobiasNx and unassigned dr0i Jun 29, 2026
Comment thread src/main/resources/alma/index-config.json
Comment on lines 420 to 431
"rpbId": {
"analyzer": "id_analyzer",
"type": "text"
},
"schoeneNummer": {
"analyzer": "id_analyzer",
"type": "text"
},
"hebisId": {
"analyzer": "id_analyzer",
"type": "text"
},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dr0i and here.

@TobiasNx

TobiasNx commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@dr0i I followed the examples in the index file 1 and 2. Also even if it is an id, the search is enabled e.g. with hbzId so that we can search for HT* and almaMmsId for *6441 Similar actions are true for hebisId and rpbId if I am not mistaken (this could be answered by @fsteeg). So the exact match query of keyword is not enough.

@TobiasNx TobiasNx requested a review from dr0i June 29, 2026 13:32
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Jun 29, 2026
@blackwinter

Copy link
Copy Markdown
Member

So the exact match query of keyword is not enough.

keywords still support prefix and wildcard queries.

@dr0i

dr0i commented Jun 29, 2026

Copy link
Copy Markdown
Member

So question boils down to: "shall these IDs be case-sensitive or not" @fsteeg ?

@dr0i

dr0i commented Jun 29, 2026

Copy link
Copy Markdown
Member

We decided to leave it as text , see #2375 (comment).

@dr0i dr0i merged commit 900dd0c into master Jun 29, 2026
1 check passed
@dr0i

dr0i commented Jun 29, 2026

Copy link
Copy Markdown
Member

Deployed. Basedump-ETL started. To be reviewed tomorrow.

@dr0i dr0i deleted the 2365-indexVerbundIds branch June 29, 2026 14:59
@dr0i dr0i assigned TobiasNx and unassigned dr0i Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants