Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The configmap template derives URL schemes (
https/http,wss/ws) fromingress.enabled AND ingress.tls.enabled. This couples TLS termination to the built-in NGINX ingress.When using an external gateway (Gateway API, LoadBalancer with TLS, Caddy, etc.) with
ingress.enabled: false, the configmap rendershttp://andws://URLs even though TLS is terminated upstream. Browsers loading the Huly UI over HTTPS get mixed-content blocking when the config serveshttp:///ws://endpoints.Fix
Add a top-level
tls.enabledvalue that controls the URL scheme independently of ingress:tls.enabled: true→https/wss(regardless of ingress)tls.enabled: false→http/wstls.enabled: ""(default, unset) → falls back toingress.tls.enabledfor backward compatibilityBackward compatibility
ingress.enabled=true, ingress.tls.enabled=truehttpshttps(fallback works)ingress.enabled=true, ingress.tls.enabled=falsehttphttp(fallback works)ingress.enabled=false(Gateway API)http(broken)http(fallback) — settls.enabled=trueto fixingress.enabled=false, tls.enabled=truehttps(new fix)No breaking changes — existing values files render identically.