ci: bump the actions-minor-patch group across 1 directory with 2 updates - #1521
ci: bump the actions-minor-patch group across 1 directory with 2 updates#1521dependabot[bot] wants to merge 3 commits into
Conversation
JerrettDavis
left a comment
There was a problem hiding this comment.
Requesting changes because this is not just the Dependabot commitlint failure: the CI build-wheel and build jobs also failed after the workflow action bumps. The diff itself is small, but we should not merge a workflow/toolchain update while the affected build path is red. Please either adjust the action versions to ones that keep the CI build path green or split the Rust toolchain and PyPI publish action bumps so the failing update is isolated.
293e3ea to
ec0eae8
Compare
JerrettDavis
left a comment
There was a problem hiding this comment.
The workflow action bump is still not merge-ready. The latest run still has a failing commitlint check for the Dependabot commit title, and the CI build-wheel and build jobs are also failing on this head.
Because this PR changes CI/release workflow actions, it needs the affected build path green before merging. Please either choose action versions that keep the CI build jobs passing, or split the Rust toolchain and PyPI publish action updates so the failing update is isolated.
ec0eae8 to
3d1565b
Compare
|
@dependabot rebase |
3d1565b to
395a6d5
Compare
395a6d5 to
56f3845
Compare
JerrettDavis
left a comment
There was a problem hiding this comment.
Reviewed the refreshed diff after narrowing this PR to the valid pypa/gh-action-pypi-publish v1.14.0 update only. The invalid Rust toolchain pin was removed, and the amended commit message should satisfy commitlint.
Approving the workflow-only update; the fresh CI run is still queued on the new SHA.
JerrettDavis
left a comment
There was a problem hiding this comment.
Thanks for the rerun. I need to pull back my prior approval because the current head still leaves required CI red.
The remaining failure is test (4), and it fails before pytest starts while trying to download the headroom-wheel artifact:
Unable to download artifact(s): Artifact not found for name: headroom-wheel
That means the workflow graph/artifact naming is still incompatible with the updated publish-action path. Please adjust the workflow so the build-wheel artifact uploaded by this run is available under the headroom-wheel name before the test shards download it, then rerun the full workflow.
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps the actions-minor-patch group with 2 updates in the / directory: [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) and [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `dtolnay/rust-toolchain` from 1.96.0 to 1.100.0 - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@1.96.0...1.100.0) Updates `pypa/gh-action-pypi-publish` from 1.13.0 to 1.14.2 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.13.0...v1.14.2) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-version: 1.100.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor-patch - dependency-name: pypa/gh-action-pypi-publish dependency-version: 1.14.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
56f3845 to
af1635c
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the actions-minor-patch group with 2 updates in the / directory: dtolnay/rust-toolchain and pypa/gh-action-pypi-publish.
Updates
dtolnay/rust-toolchainfrom 1.96.0 to 1.100.0Commits
fef302ctoolchain: 1.100.0Updates
pypa/gh-action-pypi-publishfrom 1.13.0 to 1.14.2Release notes
Sourced from pypa/gh-action-pypi-publish's releases.
... (truncated)
Commits
dc37677Merge pull request #417 from trail-of-forks/ft/bump-deps8b2f234Bumppypi-attestationsandsigstore78b72dbMerge pull request #416 from takluyver/twine-v792f4d2aUpdate twine to v7ba38be9Merge pull request #408 from adisivaprasad/bump-setup-python-v6a6c5088Bump actions/setup-python from v5.6.0 to v6.2.0cef2210Merge pull request #397 from whitequark/patch-1b4595e2Enableverboseandprint-hashby default.e2bab26Merge pull request #395 from him2him2/docs/fix-typos-and-grammar7495c38docs: fix typos and grammar in README and SECURITY