refactor(proxy): isolate semantic cache key policy - #1964
Merged
Conversation
Contributor
PR governanceThis PR follows the template and is marked ready for human review. |
JerrettDavis
force-pushed
the
jd/architecture-slice-21
branch
from
July 11, 2026 00:11
25659dd to
96f3989
Compare
JerrettDavis
marked this pull request as draft
July 11, 2026 05:00
Collaborator
Author
|
Marking this back to draft during PR maintenance: the branch is currently conflicted against main, and gh pr update-branch cannot update it automatically. It should come back to ready-for-review only after manual conflict resolution/rebase and fresh CI on the new head. |
JerrettDavis
marked this pull request as ready for review
July 11, 2026 05:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts proxy semantic response-cache key normalization and hashing into a pure
semantic_cache_key_policymodule.SemanticCachekeeps ownership of storage, locking, TTL, and LRU behavior while the deterministic cache-key formula is directly tested as a standalone policy.Closes #
Type of Change
Changes Made
headroom.proxy.semantic_cache_key_policywith recursivecache_controlstripping and semantic cache key hashing.SemanticCache._compute_keyto delegate to the pure key policy while preserving its existing private wrapper contract.Testing
pytest)ruff check .)mypy headroom)Test Output
Real Behavior Proof
headroomlabs/main.Review Readiness
Checklist
Screenshots (if applicable)
N/A
Additional Notes
Documentation and changelog updates are not applicable for this internal architecture slice. PR-specific GHAS checks will be monitored after opening.