refactor(proxy): extract tool injection logging - #2009
Merged
Conversation
Contributor
PR governanceThis PR follows the template and is marked ready for human review. |
JerrettDavis
force-pushed
the
jd/architecture-slice-46
branch
from
July 10, 2026 23:57
4379034 to
1c0e625
Compare
…-slice-46 # Conflicts: # headroom/proxy/helpers.py
# Conflicts: # headroom/proxy/helpers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts proxy tool-injection decision logging from
headroom.proxy.helpersinto a focused logging policy module. The public helper function remains in place and delegates to the new module, so existing injection call sites keep their current API while the logging format has direct tests.Closes #
Type of Change
Changes Made
headroom.proxy.tool_injection_loggingwith the sharedToolInjectionDecisiontype and structured logging helper.helpers.log_tool_injection_decisionto delegate to the logging policy module while preserving the existing helper API.Testing
pytest)ruff check .)mypy headroom)Test Output
Real Behavior Proof
headroomlabs/mainatd2170b19.Review Readiness
Checklist
Screenshots (if applicable)
N/A.
Additional Notes
Documentation and changelog updates are not applicable for this internal refactor. The push reported existing default-branch Dependabot vulnerabilities; this PR's staged gitleaks scan passed and CI security checks are expected to validate the branch.