Add default parameters to library I/O functions#324
Open
mark-magdy wants to merge 1 commit intoheitzmann:mainfrom
Open
Add default parameters to library I/O functions#324mark-magdy wants to merge 1 commit intoheitzmann:mainfrom
mark-magdy wants to merge 1 commit intoheitzmann:mainfrom
Conversation
- read_gds: tolerance, shape_tags, error_code now optional - read_oas: tolerance, error_code now optional - gds_timestamp: new_timestamp, error_code now optional - oas_validate: signature, error_code now optional Fixes compilation errors with documented examples. All changes backward compatible. Closes heitzmann#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298
Changes
Added default parameters to 4 functions in
include/gdstk/library.hpp:read_gds():tolerance,shape_tags,error_codenow optionalread_oas():tolerance,error_codenow optionalgds_timestamp():new_timestamp,error_codenow optionaloas_validate():signature,error_codenow optionalWhy
Documented C++ examples failed to compile because function signatures required all parameters explicitly. These changes allow the documented simplified calling patterns to work.
Details