Update JalaliValidator.php#180
Open
itashia wants to merge 1 commit into
Open
Conversation
Refactored outdated logic for compatibility and maintainability - Introduced class constants for default formats - Removed code duplication via helper methods - Improved type hinting for better static analysis - Used arrow functions for cleaner syntax (PHP 7.4+) - Separated concerns by extracting common tasks into dedicated methods - Leveraged `callable` for flexible comparisons - Enhanced method docblocks for better understanding This code had not been updated for a long time and was incompatible with newer PHP versions. This refactor preserves all original behavior while modernizing the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored outdated logic for compatibility and maintainability
callablefor flexible comparisonsThis code had not been updated for a long time and was incompatible with newer PHP versions. This refactor preserves all original behavior while modernizing the implementation.