enable-diagnostics option

[Axlefublr]

Combine all diagnostics options into a struct.

Previously:

editor {
   inline-diagnostics: {
      …
   }
   end-of-line-diagnostics: …
}

Now:

editor {
   diagnostics {
      enable: bool
      inline: {
         …
      }
      end-of-line: …
   }
}

New diagnostics.enable option that allows you to toggle showing any diagnostics. Rather than having to individually change the two diagnostic variants.

old pr body

Reopening #12203 by @nik-rev, taking on maintaining this pr.

I took the final form of the pr's diff into a single commit¹, and attributed nik as the author of it. I haven't needed to actually change any of the code.

¹ Easier this way so that I only need to solve merge conflicts with the latest diff of the pr, rather than every commit that comes before it.

---

enable-diagnostics option, that lets you easily toggle showing diagnostics globally.
true by default.

[Axlefublr]

Did the restructure.
I'll edit the pr body to ease in the soon-incoming angry helix users with what changed.

[LnxgpI0k]

I'm confused on the namings for different diagnostic types. What are "end of line" diagnostics? Are the diagnostics in the top right part of this PR?

[Axlefublr]

honestly? I don't even remember. but they were called end-of-line-diagnostics. Now they are called end-of-line inside of the diagnostics object

[LnxgpI0k]

Is there a command to view them once? Maybe something in the quick (space bar) menu?

[Axlefublr]

there's spaced iirc. I only use inline diagnostics ngl

[sploders101]

Is there a command to view them once? Maybe something in the quick (space bar) menu?

This is something I wanted as well. I have a working prototype of it in my personal Helix fork and was thinking about prepping it to contribute upstream.

What it does now is respect the current configuration, but add a per-document toggle (<space><C-d> or "toggle_inlay_diagnostics") that temporarily lowers the severity level of multi-line diagnostics toinfo. I'm still testing out how I like it, and have a status line indicator for it on my work laptop, but I'll have to replicate it off-hours before I can push it up

EDIT: I've pushed it to sploders101/helix personal branch. I don't think this discussion belongs here though, so if you want to bring it up in another issue, please tag me and I'll chime in with discussion and potentially a PR. Note that my personal branch is not what will end up in the PR. That's just my personal copy where I merge whatever I want. I'll have to break the changes out first, but feel free to try it as-is and provide feedback