updating the way the bufferline is displaying the buffer tabs that no… - #16226
Open
mbarutel wants to merge 1 commit into
Open
updating the way the bufferline is displaying the buffer tabs that no…#16226mbarutel wants to merge 1 commit into
mbarutel wants to merge 1 commit into
Conversation
Author
|
@aaron404, just a heads up, majority of the code that have been changed by this PR is yours. A review from you would be highly appreciated. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys! I have been a big fan of Helix for the past 2-3 months now and am looking to be a long term contributor to the project, as I don't really see myself not using Helix anytime soon! 😄
Plus, I am in the process of learning Rust, and thus I decided to work on this project to help improve my skills. 👍
The thing that I am tackling in this PR is Bufferline's rendering behavior when the amount of Tabs goes beyond the width of the viewport. Here are some before and after recording. Feedback would be greatly appreciated! 😄
In the before video, you can see that we don't have visibility on tabs beyond the width of the viewport:
https://github.com/user-attachments/assets/9219bd6a-cc53-4ea9-86c9-d616539865b4
After the changes, we keep the visibility of tabs beyond the viewport and render tab that has it's title cut off accordingly:
https://github.com/user-attachments/assets/3dbcf082-82e1-446c-9fc5-2dbf2c8ccb2e