This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Do not commit: Support fish shell completion#77
Draft
marckhouzam wants to merge 3 commits into
Draft
Conversation
marckhouzam
force-pushed
the
feat/compFish
branch
from
a1e9acd to
bc5eca3
Compare
Member
Author
|
This PR originally simply added the word It now also allows to actually test fish completions. |
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
This commit moves the creation of kube-context config files to the same file as where the rest of the configuration is setup. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
force-pushed
the
feat/compFish
branch
from
9446f5c to
61c334b
Compare
Member
Author
|
I just learned about Draft PRs 😁 |
This is a major refactor that allows to test the fish shell. Running the completion tests does not change, but now they include fish on Linux and on Mac. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
force-pushed
the
feat/compFish
branch
from
61c334b to
5ceb976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion tests adaptation for helm/helm#7690
Should only be merged once the helm PR is merged.