Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ const getSignByName = (signName, language) => {
return -2;
}

const index = getNames(language).indexOf(signName.charAt(0).toUpperCase() + signName.slice(1));
const normalizedSignName = signName.replace(/^.| ./g, (chars) => chars.toUpperCase());
const index = getNames(language).indexOf(normalizedSignName);

return getSignByIndex(index, language);
};
Expand Down
6 changes: 6 additions & 0 deletions locales/vi/elements.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[
"lửa",
"đất",
"khí",
"nước"
]
62 changes: 62 additions & 0 deletions locales/vi/zodiac.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
{
"aries": {
"name": "Bạch Dương",
"element": 0,
"stone": "huyết ngọc"
},
"taurus": {
"name": "Kim Ngưu",
"element": 1,
"stone": "lam ngọc"
},
"gemini": {
"name": "Song Tử",
"element": 2,
"stone": "mã não"
},
"cancer": {
"name": "Cự Giải",
"element": 3,
"stone": "ngọc lục bảo"
},
"leo": {
"name": "Sư Tử",
"element": 0,
"stone": "mã não đen"
},
"virgo": {
"name": "Xử Nữ",
"element": 1,
"stone": "mã não đỏ"
},
"libra": {
"name": "Thiên Bình",
"element": 2,
"stone": "đá ô liu"
},
"scorpio": {
"name": "Bọ Cạp",
"element": 3,
"stone": "ngọc xanh biển"
},
"sagittarius": {
"name": "Nhân Mã",
"element": 0,
"stone": "hoàng ngọc"
},
"capricorn": {
"name": "Ma Kết",
"element": 1,
"stone": "hồng ngọc"
},
"aquarius": {
"name": "Bảo Bình",
"element": 2,
"stone": "ngọc hồng lựu"
},
"pisces": {
"name": "Song Ngư",
"element": 3,
"stone": "thạch anh tím"
}
}
4 changes: 4 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ describe('zodiac.getSignByName(signName)', function() {
assert.deepEqual(zodiac.getSignByName('cancer', 'fr-FR'), { "name": "Cancer", "element": "eau", "stone": "émeraude", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
});

it('should get the zodiac sign\'s information based on a name (Vietnamese override)', function() {
assert.deepEqual(zodiac.getSignByName('cự giải', 'vi'), { "name": "Cự Giải", "element": "nước", "stone": "ngọc lục bảo", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
});

it('should return the error code -1 when the name is invalid', function() {
assert.deepEqual(zodiac.getSignByName('ophiuchus'), -2);
assert.deepEqual(zodiac.getSignByName(-1), -2);
Expand Down