fix: auto-spy standalone inject() services (#9397) #13310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,3 @@ | ||
| ## [14.15.1](https://github.com/help-me-mom/ng-mocks/compare/v14.15.0...v14.15.1) (2026-02-04) | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| import { | ||
| Component, | ||
| forwardRef, | ||
| Inject, | ||
| Injectable, | ||
| VERSION, | ||
| } from '@angular/core'; | ||
| import * as ngCore from '@angular/core'; | ||
| import { TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { MockBuilder, MockRender, ngMocks } from 'ng-mocks'; | ||
|
|
||
| // @see https://github.com/help-me-mom/ng-mocks/issues/9397 | ||
| describe('issue-9397', () => { | ||
| if (Number.parseInt(VERSION.major, 10) < 14) { | ||
| it('needs a14+', () => { | ||
| expect(true).toBeTruthy(); | ||
| }); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| beforeAll(() => | ||
| ngMocks.autoSpy(typeof jest === 'undefined' ? 'jasmine' : 'jest'), | ||
| ); | ||
| afterAll(() => ngMocks.autoSpy('reset')); | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| class TodoListService { | ||
| public someMethod(): void {} | ||
| } | ||
|
|
||
| @Component({ | ||
| selector: 'target-component', | ||
| template: '', | ||
| ['standalone' as never /* TODO: remove after upgrade to a14 */]: true, | ||
| }) | ||
| class TargetComponent { | ||
| public readonly todoListService = (ngCore as any).inject( | ||
| TodoListService, | ||
| ); | ||
|
|
||
| public someMethod(): void { | ||
| this.todoListService.someMethod(); | ||
| } | ||
| } | ||
|
|
||
| @Component({ | ||
| selector: 'ctor-target-component', | ||
| template: '', | ||
| ['standalone' as never /* TODO: remove after upgrade to a14 */]: true, | ||
| }) | ||
| class CtorTargetComponent { | ||
| public constructor( | ||
| @Inject(forwardRef(() => TodoListService)) | ||
| public readonly todoListService: TodoListService, | ||
| ) {} | ||
|
|
||
| public someMethod(): void { | ||
| this.todoListService.someMethod(); | ||
| } | ||
| } | ||
|
|
||
| @Component({ | ||
| selector: 'plain-ctor-target-component', | ||
| template: '', | ||
| ['standalone' as never /* TODO: remove after upgrade to a14 */]: true, | ||
| }) | ||
| class PlainCtorTargetComponent { | ||
| public constructor( | ||
| public readonly todoListService: TodoListService, | ||
| ) {} | ||
|
|
||
| public someMethod(): void { | ||
| this.todoListService.someMethod(); | ||
| } | ||
| } | ||
|
|
||
| class SyntheticProvidedShapeService { | ||
| public someMethod(): void {} | ||
| } | ||
|
|
||
| (SyntheticProvidedShapeService as any)['ɵprov'] = { | ||
| providedIn: 'root', | ||
| }; | ||
|
|
||
| @Component({ | ||
| selector: 'detached-target-component', | ||
| template: '', | ||
| ['standalone' as never /* TODO: remove after upgrade to a14 */]: true, | ||
| }) | ||
| class DetachedTargetComponent { | ||
| public readonly detached = new TodoListService(); | ||
|
|
||
| public readonly empty = null; | ||
|
|
||
| public readonly synthetic = new SyntheticProvidedShapeService(); | ||
| } | ||
|
|
||
| beforeEach(() => MockBuilder(TargetComponent)); | ||
|
|
||
| it('auto-spies services injected via inject()', () => { | ||
| const fixture = MockRender(TargetComponent); | ||
| const component = fixture.point.componentInstance; | ||
| const todoListService = TestBed.inject(TodoListService); | ||
|
|
||
| component.someMethod(); | ||
|
|
||
| expect(todoListService.someMethod).toHaveBeenCalledTimes(1); | ||
| expect(component.todoListService.someMethod).toBe( | ||
| todoListService.someMethod, | ||
| ); | ||
| }); | ||
|
|
||
| describe('control', () => { | ||
| beforeEach(() => MockBuilder(CtorTargetComponent)); | ||
|
|
||
| it('auto-spies services injected via constructor', () => { | ||
| const fixture = MockRender(CtorTargetComponent); | ||
| const component = fixture.point.componentInstance; | ||
| const todoListService = TestBed.inject(TodoListService); | ||
|
|
||
| component.someMethod(); | ||
|
|
||
| expect(todoListService.someMethod).toHaveBeenCalledTimes(1); | ||
| expect(component.todoListService.someMethod).toBe( | ||
| todoListService.someMethod, | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('plain ctor control', () => { | ||
| beforeEach(() => MockBuilder(PlainCtorTargetComponent)); | ||
|
|
||
| it('keeps constructor-based auto-spy for plain parameters', () => { | ||
| const fixture = MockRender(PlainCtorTargetComponent); | ||
| const component = fixture.point.componentInstance; | ||
| const todoListService = TestBed.inject(TodoListService); | ||
|
|
||
| component.someMethod(); | ||
|
|
||
| expect(todoListService.someMethod).toHaveBeenCalledTimes(1); | ||
| expect(component.todoListService.someMethod).toBe( | ||
| todoListService.someMethod, | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('guards', () => { | ||
| beforeEach(() => MockBuilder(DetachedTargetComponent)); | ||
|
|
||
| it('skips standalone properties which are not the injected singleton', () => { | ||
| const fixture = MockRender(DetachedTargetComponent); | ||
| const component = fixture.point.componentInstance; | ||
|
|
||
| expect(component.detached.someMethod).toBe( | ||
| TodoListService.prototype.someMethod, | ||
| ); | ||
| expect(component.synthetic.someMethod).toBe( | ||
| SyntheticProvidedShapeService.prototype.someMethod, | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper is gated to components only via
isNgDef(template, 'c'), but this render path also serves standalone directives, and the pipe wrapper case reaches the same area too. A standalone directive or pipe that usesinject()still appears to bypass auto-spy support, so either the guard needs widening or the narrower scope should be documented and covered explicitly.