Skip to content

fix: keep useFactory root providers for kept injectables (#7938)#13468

Open
satanTime wants to merge 1 commit intohelp-me-mom:mainfrom
satanTime:issues/7938
Open

fix: keep useFactory root providers for kept injectables (#7938)#13468
satanTime wants to merge 1 commit intohelp-me-mom:mainfrom
satanTime:issues/7938

Conversation

@satanTime
Copy link
Copy Markdown
Member

@satanTime satanTime commented Mar 28, 2026

Closes #7938

Summary

  • preserve kept root injectables that are backed by useFactory metadata
  • add a regression for NonNullableFormBuilder kept alongside ReactiveFormsModule
  • document the explicit keep requirement for NonNullableFormBuilder in the FAQ
  • keep the regression Angular-10-safe by resolving NonNullableFormBuilder at runtime

Validation

  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh root
  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh a5es5
  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh a10
  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh a14
  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh a20
  • COMPOSE_PROJECT_NAME=ngmocks_7938_1774684993 sh test.sh coverage

@satanTime satanTime force-pushed the issues/7938 branch 2 times, most recently from 2c75bea to 2d0cbb4 Compare March 28, 2026 09:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (46e4423) to head (1c909c0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main    #13468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          228       229    +1     
  Lines         4168      4175    +7     
  Branches      1187      1192    +5     
=========================================
+ Hits          4168      4175    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@satanTime satanTime force-pushed the issues/7938 branch 3 times, most recently from fcf2581 to 9b5a94a Compare March 28, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: .keep(ReactiveFormsModule) does not actually keep

1 participant