Skip to content

feat: support for cookie consent check on javascripts tags using Pressidium - #1406

Open
michaelclaesson wants to merge 1 commit into
helsingborg-stad:mainfrom
michaelclaesson:feat/pressidium-cookie-consent-js-tags
Open

feat: support for cookie consent check on javascripts tags using Pressidium#1406
michaelclaesson wants to merge 1 commit into
helsingborg-stad:mainfrom
michaelclaesson:feat/pressidium-cookie-consent-js-tags

Conversation

@michaelclaesson

Copy link
Copy Markdown
Contributor

No description provided.

@michaelclaesson
michaelclaesson force-pushed the feat/pressidium-cookie-consent-js-tags branch from c38c0b3 to 30f4771 Compare May 16, 2025 17:28
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sebastianthulin

Copy link
Copy Markdown
Member

In this PR you are handling cookies backend. I'm not entierly shure, but this may be affected negatively on cache (rendering the common cache unusable). A possible solution is to use localStorage or similar tech.

@sebastianthulin

Copy link
Copy Markdown
Member

This PR needs to handle the cache in a separate vary, a vary can be implemented like this: https://github.com/helsingborg-stad/Municipio/blob/main/library/Integrations/Litespeed/Cache/UserGroupVary.php

@sebastianthulin

Copy link
Copy Markdown
Member

I have added a cookie consent vary here:
#1701

@sebastianthulin

Copy link
Copy Markdown
Member

Since this is some sort of integration, this feature should be placed in Integrations/Pressidium/Admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants