Skip to content

refactor: optimize VTK conversion #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henry2004y merged 6 commits into from
May 18, 2026
+103 −76
Merged

refactor: optimize VTK conversion #167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3c5de0
refactor: optimize VTK conversion
henry2004y May 16, 2026
1f44425
refactor codes
henry2004y May 16, 2026
6e1c3bf
fix introduced bug
henry2004y May 16, 2026
dad653b
Fix Int32/Int64 mismatch
henry2004y May 16, 2026
bfde72b
optimization
henry2004y May 17, 2026
f8aa842
Formatting
henry2004y May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions benchmark/Artifacts.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[testdata]
git-tree-sha1 = "d884abbeac09834475c56b256659becc1da64927"
lazy = true

[[testdata.download]]
url = "https://github.com/henry2004y/batsrus_data/raw/master/batsrus_data.tar.gz"
sha256 = "e344560deced105e684ed975276f34d7003427f5337c7e4b1def8274e5470a23"
3 changes: 2 additions & 1 deletion benchmark/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
Batsrus = "e74ebddf-6ac1-4047-a0e5-c32c99e57753"
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
CodecZlib = "944b1d66-785c-5afd-91f1-9de20f533193"
HDF5 = "f67ccb44-e63f-5c2f-98bd-6dc0ccc4ba2f"
HDF5 = "f67ccb44-e63f-5c2f-98bd-6dc0ccc4ba2f"
LazyArtifacts = "4af54fe1-eca0-43a8-85a7-787d91b784e3"
13 changes: 9 additions & 4 deletions benchmark/benchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using BenchmarkTools, Downloads, Tar, CodecZlib, HDF5
using BenchmarkTools, Downloads, Tar, CodecZlib, HDF5, LazyArtifacts

t = @elapsed using Batsrus
println("Julia version is $VERSION")
Expand Down Expand Up @@ -93,6 +93,11 @@ SUITE["amrex"]["phase_space_3d"] = @benchmarkable get_phase_space_density(

# Helper for file-based selection benchmark (lazy load)
amrex_data_unloaded = AMReXParticle(amrex_dir)
SUITE["amrex"]["select_region_from_files"] = @benchmarkable select_particles_in_region(
$amrex_data_unloaded, x_range = (2.5, 4.5)
)

SUITE["vtk"] = BenchmarkGroup()
datapath_vtk = artifact"testdata"
filetag_vtk = joinpath(datapath_vtk, "3d_mhd_amr/3d__mhd_1_t00000000_n00000000")
batl_vtk = Batl(readhead(filetag_vtk * ".info"), readtree(filetag_vtk)...)

SUITE["vtk"]["getConnectivity"] = @benchmarkable getConnectivity($batl_vtk)
SUITE["vtk"]["find_grid_block"] = @benchmarkable Batsrus.find_grid_block($batl_vtk, [0.0, 0.0, 0.0])
Loading
Loading