refactor(webapp): let one registry name a standing

The same five standings carried three sets of words: the badge said "Nothing to
report yet", the practice node on the detail page said "No occasion yet", and
the ring legend said "No opportunity" — and the legend sits directly above the
badge it disagreed with. `webapp/AGENTS.md` puts the rule plainly: nothing but
the registry may hold words, a colour or an icon for an enum value.

The legend and the nodes now read their words from the standing registry, which
gains a `shortLabel` for the one place five entries share a row. The nodes keep
their own glyph and colour, which the registry does not describe, and
`UNMEASURED` stays with them because it is not a standing the server reports but
the client's word for a practice it sent none for.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MAQxdMw579siMh1wXKEEh4

Author: Valentin Grüner

webapp/src/components/profile/PracticeGroupStandingRing.tsx

@@ -1,18 +1,38 @@
 import type { PracticeStanding } from "@/api/types.gen";
+import { PRACTICE_GROUP_STANDING_BADGE } from "./practice-group-standing-presentation";
 
 type Standing = PracticeStanding["standing"];
 
+/**
+ * Ring order is worst-first, so the segment a reader should act on starts at twelve o'clock. The
+ * words come from the standing registry rather than from here — the legend this feeds sits directly
+ * above the badge that names the same value.
+ */
+const SEGMENT_ORDER: readonly Standing[] = [
+	"DEVELOPING",
+	"MIXED",
+	"STRENGTH",
+	"NOT_OBSERVED",
+	"NO_OPPORTUNITY",
+];
+
+const SEGMENT_COLORS: Record<Standing, string> = {
+	DEVELOPING: "text-destructive",
+	MIXED: "text-warning",
+	STRENGTH: "text-success",
+	NOT_OBSERVED: "text-muted-foreground/75",
+	NO_OPPORTUNITY: "text-muted-foreground/45",
+};
+
 const SEGMENTS: ReadonlyArray<{
 	standing: Standing;
 	colorClass: string;
 	label: string;
-}> = [
-	{ standing: "DEVELOPING", colorClass: "text-destructive", label: "Needs attention" },
-	{ standing: "MIXED", colorClass: "text-warning", label: "Mixed" },
-	{ standing: "STRENGTH", colorClass: "text-success", label: "Going well" },
-	{ standing: "NOT_OBSERVED", colorClass: "text-muted-foreground/75", label: "Not observed" },
-	{ standing: "NO_OPPORTUNITY", colorClass: "text-muted-foreground/45", label: "No opportunity" },
-];
+}> = SEGMENT_ORDER.map((standing) => ({
+	standing,
+	colorClass: SEGMENT_COLORS[standing],
+	label: PRACTICE_GROUP_STANDING_BADGE[standing].shortLabel,
+}));
 
 export const STANDING_LEGEND = SEGMENTS;
 

webapp/src/components/profile/practice-group-standing-presentation.ts

@@ -1,74 +1,53 @@
-import {
-	GitPullRequestIcon,
-	IssueOpenedIcon,
-	type Icon as OcticonComponent,
-} from "@primer/octicons-react";
-import type { FeedbackSourceCount, PracticeGroupStanding } from "@/api/types.gen";
-import { type BrandIcon, SlackIcon } from "@/components/icons/brand";
+import type { PracticeGroupStanding } from "@/api/types.gen";
 
 export type PracticeGroupStandingKey = PracticeGroupStanding["standing"];
 
-const VERDICT_STANDINGS = ["DEVELOPING", "MIXED", "STRENGTH"] as const;
-
-export function isVerdictStanding(standing: PracticeGroupStandingKey): boolean {
-	return (VERDICT_STANDINGS as readonly string[]).includes(standing);
-}
-
+/**
+ * The one place a standing gets words and a colour. The badge, the ring legend and the practice
+ * nodes on the detail page all read from here — they used to carry three spellings, and the legend
+ * sat directly above a badge that disagreed with it.
+ *
+ * `shortLabel` is for the ring legend, where five entries share one row and the badge's full phrase
+ * does not fit; it says the same thing in fewer words and is never a different word.
+ */
 export const PRACTICE_GROUP_STANDING_BADGE: Record<
 	PracticeGroupStandingKey,
 	{
 		label: string;
+		shortLabel: string;
 		variant: "destructive" | "warning" | "success" | "outline";
-		ringClass?: string;
 		explanation: string;
 	}
 > = {
 	DEVELOPING: {
 		label: "Needs attention",
+		shortLabel: "Needs attention",
 		variant: "destructive",
-		ringClass: "ring-destructive/40 dark:ring-destructive/50",
 		explanation: "Recent reviews raised problems in this group.",
 	},
 	MIXED: {
 		label: "Mixed feedback",
+		shortLabel: "Mixed",
 		variant: "warning",
-		ringClass: "ring-warning/40 dark:ring-warning/50",
 		explanation: "Recent reviews found both strengths and problems here.",
 	},
 	STRENGTH: {
 		label: "Going well",
+		shortLabel: "Going well",
 		variant: "success",
-		ringClass: "ring-success/40 dark:ring-success/50",
 		explanation: "Nothing needs your attention here right now.",
 	},
 	NOT_OBSERVED: {
 		label: "Not observed yet",
+		shortLabel: "Not observed",
 		variant: "outline",
 		explanation: "These practices have not been observed in your reviewed work yet.",
 	},
 	NO_OPPORTUNITY: {
 		label: "Nothing to report yet",
+		shortLabel: "Nothing to report",
 		variant: "outline",
 		explanation:
 			"Your recent work was reviewed, but it either offered no opportunity for these practices or raised nothing worth mentioning.",
 	},
 };
-
-export const PRACTICE_GROUP_SOURCE_META: Partial<
-	Record<
-		FeedbackSourceCount["workKind"],
-		{ Icon: OcticonComponent | BrandIcon; singular: string; plural: string }
-	>
-> = {
-	"scm.pull_request": {
-		Icon: GitPullRequestIcon,
-		singular: "pull request",
-		plural: "pull requests",
-	},
-	"scm.issue": { Icon: IssueOpenedIcon, singular: "issue", plural: "issues" },
-	"chat.conversation_thread": {
-		Icon: SlackIcon,
-		singular: "Slack conversation",
-		plural: "Slack conversations",
-	},
-};