-
Notifications
You must be signed in to change notification settings - Fork 2
feat(server): Java webhook runtime role; restarts no longer drop events #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ce1c307
745911c
25bed93
755d667
06fe002
af9656e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| --- | ||||||
| mode: agent | ||||||
| description: Validate, branch, commit, and create PR following Hephaestus conventions | ||||||
| subtask: true | ||||||
| --- | ||||||
|
|
||||||
| # Land PR | ||||||
|
|
@@ -21,9 +21,8 @@ git diff --name-only HEAD | |||||
|
|
||||||
| Map paths to components (mirrors CI's dorny/paths-filter config): | ||||||
| - `webapp/**` → webapp changed | ||||||
| - `server/**` OR `scripts/db-utils.sh` → app-server changed | ||||||
| - `webhook-ingest/**` → webhook changed | ||||||
| - `package.json` OR `package-lock.json` OR `.node-version` → webapp + webhook changed | ||||||
| - `server/**` OR `scripts/db-utils.sh` → app-server changed (includes webhook receiver since ADR 0008) | ||||||
| - `package.json` OR `package-lock.json` OR `.node-version` → webapp changed | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lockfile change detection misses pnpm lockfile updates. This mapping tracks Suggested adjustment-- `package.json` OR `package-lock.json` OR `.node-version` → webapp changed
+- `package.json` OR `pnpm-lock.yaml` OR `.node-version` → webapp changed📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| - `docs/**` → docs-only (skip all validation if nothing else changed) | ||||||
|
|
||||||
| ## 3. Format | ||||||
|
|
@@ -59,26 +58,14 @@ pnpm run db:draft-changelog | |||||
| pnpm run db:generate-erd-docs | ||||||
| ``` | ||||||
|
|
||||||
| ## 6. Build Affected TS Services | ||||||
| ## 6. Build Affected Services | ||||||
|
|
||||||
| If webhook changed: | ||||||
|
|
||||||
| ```bash | ||||||
| pnpm run build:webhook-ingest | ||||||
| ``` | ||||||
|
|
||||||
| Build failures catch path alias and import issues that typecheck alone misses. | ||||||
| (No standalone TS services left — webhook receiver is part of `server/`.) | ||||||
|
|
||||||
| ## 7. Unit Tests for Affected Components | ||||||
|
|
||||||
| Run ONLY tests for changed components. Order: fastest first. | ||||||
|
|
||||||
| If webhook changed: | ||||||
|
|
||||||
| ```bash | ||||||
| pnpm run test:webhook-ingest | ||||||
| ``` | ||||||
|
|
||||||
| If webapp changed: | ||||||
|
|
||||||
| ```bash | ||||||
|
|
@@ -138,7 +125,7 @@ git commit -m "<type>(<scope>): <description>" | |||||
|
|
||||||
| **Scopes:** | ||||||
|
|
||||||
| - Service: `webapp`, `server`, `ai`, `webhooks`, `docs` | ||||||
| - Service: `webapp`, `server`, `docs` | ||||||
| - Infra (no release): `ci`, `config`, `deps`, `deps-dev`, `docker`, `scripts`, `security`, `db`, `no-release` | ||||||
| - Feature: `gitprovider`, `leaderboard`, `mentor`, `notifications`, `profile`, `teams`, `workspace` | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build-failure guidance is scoped too narrowly.
The “Build failure” row currently validates only webapp builds. For server-side compile/build failures, this sends contributors down the wrong path.
Suggested adjustment
📝 Committable suggestion
🤖 Prompt for AI Agents