feat(profile): add practice-area development profile - #1448
feat(profile): add practice-area development profile#1448ValentinGruener wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…etail view The weight badge paired text-background with a translucent muted-foreground, which fails contrast; the expanded feed entry used h4 labels directly under the section's h2, skipping a heading level. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GitHub delivers webhooks to the app's single configured URL, so a preview never receives the events that start a practice review — a full-stack change cannot be exercised there. Passing the flag through makes the existing dev trigger reachable per deploy; it stays off unless the variable is set. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Superseded by stack #1488 — #1486 (server API, spec and generated client) and #1487 (profile surfaces). The repository adopted stacked pull requests in #1452 after this PR was consolidated, so the reason for carrying all three parts in one PR no longer holds. The work has also been rebased onto current |
Description
Adds the practice-area development profile: developers can see where they stand in each practice area of their workspace, and open an area to understand how that standing came about.
The feed deliberately shows raw history including superseded runs — it is an activity monitor, while the status above stays latest-run and quarantine filtered; an info affordance in the section header explains that difference.
Review hint: the three parts are three separate commits (API → cards → detail page), so the diff can be read commit by commit.
How to test
Server —
mvn verify -P'!quick'coversPracticeAreaStatusIntegrationTestandObservationControllerIntegrationTest: status derivation, NO_DATA shape, quarantine floor, cross-workspace isolation, the new filters and severity sorting.Webapp —
pnpm run test:webapp; Storybook (pnpm --filter webapp run storybook) has every state underComponents/Profile/PracticeAreaStatusCardandComponents/Profile/PracticeAreaDetailPage. The detail page'sOverviewstory is interactive: select practice nodes, filter, sort, expand entries;ManyPracticesshows the diagram at ten practices.In the app — open your own profile in a workspace with practices enabled and completed reviews, then open a card via "See details". The section only renders on the own profile, because the endpoint derives the caller's standing.
Checklist
Screenshots
Storybook covers every state; see the two component sections named above.