refactor(server): standardize practice groups and feedback responses - #1539
Merged
FelixTJDietrich merged 14 commits intoAug 27, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📚 Documentation Preview
|
2 tasks
FelixTJDietrich
force-pushed
the
feat/practice-area-server
branch
from
August 27, 2026 16:31
7135992 to
b164e38
Compare
FelixTJDietrich
force-pushed
the
review/practice-area-server
branch
from
August 27, 2026 16:32
668465b to
0ea7787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes practice group the canonical product term for related practices and aligns the database, server, REST API, generated client, existing administration UI, tests, and documentation. It also tightens the standing, trend, review-run, and feedback-response contracts introduced by the parent API PR so the stack can merge with one coherent public model.
This is a required correction stacked on #1486. Merge this PR into
feat/practice-area-serverbefore merging #1486 intomain; then restack the developer-profile UI in #1487 on the corrected contract.What changes
PracticeGroup,groupSlug,groupName, and/practice-groupsconsistently across persistence, Java, OpenAPI, the generated TypeScript client, and the existing catalog UI.PUTreplaces it,GETreads it, and idempotentDELETEwithdraws it. Omitted usefulness or resolution values are cleared by replacement.REST resources
All developer-facing reads require authentication and return data only for the signed-in developer.
Compatibility and migration
The standing and review-run resources have not shipped, so this stack corrects their names without preserving aliases for abandoned contracts. Direct API callers using the retired practice-area, learner-projection, or reaction contracts must migrate as documented in
MIGRATION.md; the bundled generated client is updated in the same release.Liquibase automatically renames the affected tables, columns, indexes, constraints, and revision projections. Released changelogs remain untouched. Existing feedback-response history and append-only configuration-audit history are preserved; historical audit values are translated when read rather than rewritten. No manual data migration or new configuration is required.
How to test
CI runs every repository gate applicable to this stack. To reproduce the main local checks:
Focused server verification:
Manual API smoke test as an authenticated workspace member:
GETno longer returns a resolution.GETreports no current response.400.Checklist
.changeset/README.md**Operators:** …) andMIGRATION.mdis updated