build(server): migrate Java formatting to Spotless - #1541
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
44b9174 to
5cbd076
Compare
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
1 similar comment
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
📚 Documentation Preview
|
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
e9a2c33 to
5cbd076
Compare
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
5cbd076 to
a4c1ea0
Compare
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
Description
Migrates Java formatting from
prettier-plugin-javato Maven-native Spotless with Palantir Java Format. This removes Java's Node-based formatting path, keeps generated clients outside the formatter scope, and makes Mavenverifyenforce the complete handwritten application tree.This builds on #1529, which introduced the application/generated-client module boundary and has now merged.
What changed
spotless:checkto Mavenverifyforapplicationmain and test sources;application/target/spotless-index;pnpm run format,format:check, andcheckcommands;.git-blame-ignore-revs.Generated clients are excluded structurally by configuring Spotless only in the
applicationmodule. No import sorting, unused-import removal, ratcheting, or semantic cleanup is included.Performance
On the same warm local checkout used for the migration audit:
pnpm run checkThe warm Spotless check used its explicit local index. CI does not cache that index.
Fixes #1464
How to test
pnpm run formatpnpm run checkpnpm run test:server:unit— 6,784 tests passedspotless:applytwice and confirmed the second run was byte-idempotentspotless:checkand Mavenverifyrejected itChecklist