Skip to content

fix(webapp): preserve complete practice feedback responses - #1698

Merged
FelixTJDietrich merged 2 commits into
feat/practice-area-webappfrom
review/practice-groups-production-hardening
Sep 1, 2026
Merged

fix(webapp): preserve complete practice feedback responses#1698
FelixTJDietrich merged 2 commits into
feat/practice-area-webappfrom
review/practice-groups-production-hardening

Conversation

@FelixTJDietrich

@FelixTJDietrich FelixTJDietrich commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Hardens the practice-group feedback flow introduced by #1487. A dispute is now submitted only when its required explanation is available, and a failed request keeps the complete response ready for retry instead of dropping the dispute resolution.

Practice and expanded-observation selections are also stored in validated URL search parameters. Refreshing or sharing the page preserves its context, while Back and Forward move through selection changes as expected.

This review follow-up also removes redundant implementation commentary from the new profile components and corrects the API migration guidance with the retired endpoint, replacement method and path, and request-field mapping.

How to test

  1. Open your own practice-group page and expand feedback that has no existing explanation.
  2. Select Disputed. Confirm that the explanation becomes required and no request is sent yet.
  3. Enter an explanation and save it. Confirm that one request contains the resolution, explanation, and any existing usefulness response.
  4. Simulate a failed save and retry. Confirm that Disputed remains selected and the retry sends the same complete response.
  5. Open feedback that already has an explanation and select Disputed. Confirm that it can be submitted immediately without losing the existing explanation or usefulness response.
  6. Select a practice and expand an observation. Refresh the page, open its URL in another tab, and use Back and Forward; confirm that each view restores the expected selection.

Automated verification:

pnpm run format
pnpm run check
pnpm run test:webapp
pnpm --filter webapp run build

Checklist

  • My changeset summary reads as an operator/user-facing note (it becomes the changelog entry) — see .changeset/README.md
  • If operators must act, the changeset and migration entry give actionable upgrade instructions
  • I did not commit generated-artifact changes that this PR did not cause

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: bd5ee225-16c4-46df-b186-2f236a44ed5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added webapp React app: UI components, routes, state management size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Sep 1, 2026
@github-actions github-actions Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 1, 2026
@FelixTJDietrich FelixTJDietrich changed the title fix(webapp): harden practice feedback responses fix(webapp): preserve complete practice feedback responses Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📚 Documentation Preview

Preview has been removed (PR closed)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🧩 Storybook Preview

Preview has been removed (PR closed)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically: @FelixTJDietrich is listed in the REVIEW_POLICY_MAINTAINERS repository variable, which the repository treats as satisfying the review requirement. See the review policy in docs/contributor/ci-cd.mdx.

@FelixTJDietrich
FelixTJDietrich added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit b6f073f Sep 1, 2026
71 of 82 checks passed
@FelixTJDietrich
FelixTJDietrich deleted the review/practice-groups-production-hardening branch September 1, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files. webapp React app: UI components, routes, state management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant