Warn about android attributes mismatch for properties and function parameters#1761
Merged
pwrobeldev merged 6 commits intoJun 4, 2025
Conversation
The new function is created from the body of lambda. So far no changes in logic is implemented. The new function will be used for recursive calls for getter/setter of properties and parameters of functions. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
… property This change introduces handling of validation for accessors of LimeProperty. The initial code was not validating the accessors, because they are not added to reference map of LimeModel when it is loaded. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
This change introduces handling of validation for renaming parameters of functions. The initial code was not doing it, because parameters are not present in reference map of LimeModel when it is loaded. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
…or disabled This change introduces tests of the new logic with werror flag disabled in order to confirm, that in such case only warning is printed and the validation reports success. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
pwrobeldev
marked this pull request as ready for review
June 4, 2025 08:16
amogbetkar
approved these changes
Jun 4, 2025
pwrobeldev
deleted the
pwrobeldev/warn-about-android-attributes-mismatch-for-properties-and-param-names
branch
June 4, 2025 08:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces handling of validation for accessors
of properties and parameters of functions. The initial code was not
doing it, because neither accessors nor parameters are present in
the reference map of LimeModel when it is loaded.