Skip to content

Allow BOM module to be inferred from setting key#47

Merged
dmitriy-abramov merged 1 commit into
heremaps:masterfrom
vrozov:settingKey
Nov 25, 2025
Merged

Allow BOM module to be inferred from setting key#47
dmitriy-abramov merged 1 commit into
heremaps:masterfrom
vrozov:settingKey

Conversation

@vrozov

@vrozov vrozov commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Support use case like:

lazy val bomModuleID = settingKey[ModuleID]("bom module ID")
bomModuleID:= ModuleID(organization, name, version)
lazy val bom = Bom.dependencies(bomModuleID)

when, for example, version may not be hardcoded into the SBT build and is obtained from pom file like in apache/spark#52760 (comment)

@dmitriy-abramov

Copy link
Copy Markdown
Collaborator

@vrozov thank you for you contribution! Please run scala formatting as it is failing for your MR.

@dmitriy-abramov

Copy link
Copy Markdown
Collaborator

@vrozov I am ready to approve and merge the MR as soon the CI is green. The code looks good.

Signed-off-by: Vlad Rozov <vrozov@apache.org>
@dmitriy-abramov
dmitriy-abramov merged commit 972d941 into heremaps:master Nov 25, 2025
3 checks passed
@vrozov

vrozov commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

@dmitriy-abramov Thank you! Will it be possible to publish a new version of the plugin with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants