You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove wildcard hosts for pcscf, icscf, scscf, smsc, and pyhss in mysql.
I have tested in my local environment. These IMF NFs only need one kind of host, either specific or wildcard.
I prefer to keep the specific IP address as the host based on least privilege principle.
P.S. The root user with an empty password that can be accessed from a wildcard host should be treated carefully too.
But maybe you have your design that I haven't figured for now. So I opened a discussion about it before taking next step.
Remove a redundant directory of smsc which is originally used to store the pid file in runtime.
This is the work that I forgot to do at last pull request targeting similar directories of pcscf, icscf, and scscf.
Can you please elaborate on how you verified this PR?
No strict unit test, bro 😂😂
Just go over the process: 5GC Launch -> IMS Launch -> UE registration -> audio call -> video call
I don't know much test engineering
If there is anything I can give a hand
just feel free to tell me 😄😄
BTW, I should have rebased and sign the commits before issuing a PR
in order to prevent the merge branch commits
I'll try to fix it as soon as possible 🐱🏍🐱🏍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Supreeth,
In this PR, I propose to
I have tested in my local environment. These IMF NFs only need one kind of host, either specific or wildcard.
I prefer to keep the specific IP address as the host based on least privilege principle.
P.S. The root user with an empty password that can be accessed from a wildcard host should be treated carefully too.
But maybe you have your design that I haven't figured for now. So I opened a discussion about it before taking next step.
This is the work that I forgot to do at last pull request targeting similar directories of pcscf, icscf, and scscf.