Skip to content

Remove some redundant codes#632

Closed
Robin-Rhee wants to merge 0 commit into
herlesupreeth:masterfrom
Robin-Rhee:master
Closed

Remove some redundant codes#632
Robin-Rhee wants to merge 0 commit into
herlesupreeth:masterfrom
Robin-Rhee:master

Conversation

@Robin-Rhee

@Robin-Rhee Robin-Rhee commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Dear Supreeth,

In this PR, I propose to

  1. Remove wildcard hosts for pcscf, icscf, scscf, smsc, and pyhss in mysql.

I have tested in my local environment. These IMF NFs only need one kind of host, either specific or wildcard.
I prefer to keep the specific IP address as the host based on least privilege principle.

P.S. The root user with an empty password that can be accessed from a wildcard host should be treated carefully too.
But maybe you have your design that I haven't figured for now. So I opened a discussion about it before taking next step.

12
  1. Remove a redundant directory of smsc which is originally used to store the pid file in runtime.

This is the work that I forgot to do at last pull request targeting similar directories of pcscf, icscf, and scscf.

@Robin-Rhee Robin-Rhee closed this Mar 24, 2026
@Robin-Rhee Robin-Rhee reopened this Mar 24, 2026
@herlesupreeth

Copy link
Copy Markdown
Owner

Thanks for the PR.

I have tested in my local environment

Can you please elaborate on how you verified this PR?

@Robin-Rhee

Robin-Rhee commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

Can you please elaborate on how you verified this PR?

No strict unit test, bro 😂😂
Just go over the process: 5GC Launch -> IMS Launch -> UE registration -> audio call -> video call
I don't know much test engineering
If there is anything I can give a hand
just feel free to tell me 😄😄

BTW, I should have rebased and sign the commits before issuing a PR
in order to prevent the merge branch commits
I'll try to fix it as soon as possible 🐱‍🏍🐱‍🏍

@herlesupreeth

Copy link
Copy Markdown
Owner

I would suggest that you delete the docker volume used by mysql and then relaunch services to check whether this change is working well.

@Robin-Rhee

Copy link
Copy Markdown
Contributor Author

I would suggest that you delete the docker volume used by mysql and then relaunch services to check whether this change is working well.

Roger that !! 🐱‍🏍🐱‍🏍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants