Skip to content

Stop using global variable in warn_or_error_if_python_version_file_missing() #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
Apr 10, 2026
Merged

Stop using global variable in warn_or_error_if_python_version_file_missing() #2076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ fi
# as to what was a warning vs an error. In addition, several of the error messages contain similar
# content to the warnings (such as encouraging use of .python-version and major version syntax),
# which would mean duplicate content if we showed both.
python_version::warn_or_error_if_python_version_file_missing "${python_version_origin}" "${python_major_version}"
python_version::warn_or_error_if_python_version_file_missing "${python_version_origin}" "${python_major_version}" "${package_manager}"
python_version::warn_if_deprecated_major_version "${python_major_version}" "${python_version_origin}"
python_version::warn_if_patch_update_available "${python_full_version}" "${python_major_version}" "${python_version_origin}"

Expand Down
1 change: 1 addition & 0 deletions lib/python_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ function python_version::resolve_python_version() {
function python_version::warn_or_error_if_python_version_file_missing() {
local python_version_origin="${1}"
local python_major_version="${2}"
local package_manager="${3}"

if [[ "${python_version_origin}" == ".python-version" ]]; then
return 0
Expand Down