Add XCUITest target with accessibility identifiers#16
Merged
hewigovens merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive UI testing suite for the macOS application. It includes the addition of accessibility identifiers across various views (DAG, File List, Conflict Resolution, and Command Palette) to facilitate UI automation, new just commands for running UI tests, and several XCUITest scenes covering key features like annotation, command palette search, and conflict resolution. Feedback focuses on improving test reliability and performance by replacing hardcoded pauses with expectation-based waiting and optimizing element queries to avoid expensive tree traversals.
4b9d5d3 to
2258077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JayJayUITeststarget (new schemeJayJayUITests— won't slow downjust test-app) with five scene tests: Command Palette, Interdiff, File Annotate, Review & Split, Conflict Resolution..accessibilityIdentifier()on the views the tests need to target: palette text field, DAG rows (keyed by change-id prefix), file list rows (keyed by path), conflict-bar "Use Ours" / "Use Theirs" buttons. Strings centralized inSources/JayJay/Shared/AccessibilityIdentifiers.swift.SceneBasereads the fixture repo path from/tmp/jayjay-demo-fixture(the XCUITest runner is sandboxed away from $HOME, so we can't use ~/).JAYJAY_DEMO_REPOenv is honored as fallback.just test-uitop-level recipe andshell::ui-test [test_id]— no test id runs the whole bundle.swiftjob clone a colocated jayjay fixture into /tmp and runjust test-ui.Test plan
just buildpassesjust test-appstill runs only unit tests (UI tests isolated in their own scheme)xcodebuild -scheme JayJayUITests build-for-testingsucceedstestOpenAndSearchpasses locally (verified 16s runtime against a fixture clone)