fix(frontend): live step updates#2132
Merged
Merged
Conversation
…reactively observe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the standalone Workflow Run Debugger page, steps stream in real time only up to the await_requirement step. The steps that run after resume don't appear until the run finishes, then all at once. The embedded debugger in the workflow editor looks fine.
Root cause
Live workflow events are merged into the item cache ([item, WORKFLOW_RUN, runId]) by useWorkflowRunLiveUpdates, but WorkflowRunDebugger renders the run from the useFind collection, read non-reactively via getFromCache. So item-cache merges never re-render the component. The compensating collection "touch" ([...collection]) is deduped to a no-op by React Query's structural sharing once the run is already in the list — so nothing re-renders until an unrelated event (a refetch, or the terminal workflow:finish) forces one. The editor only appeared to work because surrounding UI activity triggered frequent incidental re-renders that masked the issue.
Fix
Subscribe WorkflowRunDebugger to the selected run's item query via useGet, so every incremental step merge re-renders the component. The existing useFind/latestRun fallback is preserved for initial paint.