Skip to content

fix(frontend): resolve yaml action inputs completions#2136

Closed
yassinedorbozgithub wants to merge 1 commit into
mainfrom
fix/frontend-yaml-inputs-completion
Closed

fix(frontend): resolve yaml action inputs completions#2136
yassinedorbozgithub wants to merge 1 commit into
mainfrom
fix/frontend-yaml-inputs-completion

Conversation

@yassinedorbozgithub

Copy link
Copy Markdown
Collaborator

Screenshots

  • After the fix
image
  • Before the fix
image

Summary

This PR fixes YAML autocompletion for action inputs by correctly detecting the enclosing action when editing inside a task's inputs block. Completions are now resolved only for task-level action inputs and no longer incorrectly trigger within workflow-level inputs declarations.

Why

The previous detection logic could fail to identify the correct action context or confuse workflow-level and task-level inputs, resulting in missing or incorrect autocomplete suggestions. This improves the YAML editing experience and provides more accurate completions.

How to review

  • Review the logic responsible for resolving the enclosing action from the current cursor position.
  • Verify that completions are only shown inside a task's inputs block.
  • Confirm that workflow-level inputs schema declarations are ignored.

Validation

  • Verified autocompletion for multiple action types inside task inputs.
  • Confirmed no completions are shown for workflow-level inputs.
  • Tested nested tasks and different indentation levels to ensure the correct action context is resolved.

@yassinedorbozgithub yassinedorbozgithub self-assigned this Jul 16, 2026
@yassinedorbozgithub yassinedorbozgithub added the bug Something isn't working label Jul 16, 2026
@yassinedorbozgithub
yassinedorbozgithub marked this pull request as draft July 17, 2026 07:21
@yassinedorbozgithub yassinedorbozgithub added the WIP Work in progress label Jul 17, 2026
@yassinedorbozgithub

Copy link
Copy Markdown
Collaborator Author

Closed in favor of #2139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant