fix(frontend): resolve yaml action inputs completions#2136
Closed
yassinedorbozgithub wants to merge 1 commit into
Closed
fix(frontend): resolve yaml action inputs completions#2136yassinedorbozgithub wants to merge 1 commit into
yassinedorbozgithub wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closed in favor of #2139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Summary
This PR fixes YAML autocompletion for action
inputsby correctly detecting the enclosing action when editing inside a task'sinputsblock. Completions are now resolved only for task-level action inputs and no longer incorrectly trigger within workflow-levelinputsdeclarations.Why
The previous detection logic could fail to identify the correct action context or confuse workflow-level and task-level
inputs, resulting in missing or incorrect autocomplete suggestions. This improves the YAML editing experience and provides more accurate completions.How to review
inputsblock.inputsschema declarations are ignored.Validation
inputs.inputs.