Skip to content

Dynamic scoring minor update - #23

Merged
lisavader merged 3 commits into
mainfrom
find_minimum
Apr 2, 2026
Merged

Dynamic scoring minor update#23
lisavader merged 3 commits into
mainfrom
find_minimum

Conversation

@lisavader

Copy link
Copy Markdown
Collaborator

There were some minor issues with finding the best local minimum in the smoothed score distribution, which is used for dynamic thresholding.

  • Previously, local minima and maxima were only recognised when there was an immediate flip in the slope sign between bins. Therefore, any areas with slope zero were disregarded. Now, these are recognised, and the average value within the plateau is saved as local minimum / maximum.
  • The threshold used to be defined by the most extreme local minimum within the range of accepted threshold values. This was updated to be the most extreme local minimum within the two most extreme local maxima (in order to avoid picking a value that does not separate the two major peaks, which represent low and high confidence gene calls respectively).
  • Added an assertion that min threshold > max threshold.

@lisavader
lisavader requested a review from lhon as a code owner April 2, 2026 12:39
@lisavader
lisavader merged commit 80768b2 into main Apr 2, 2026
4 checks passed
@lisavader
lisavader deleted the find_minimum branch April 2, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant