fix: remove @ts-ignore from OAuth Store makeAutoObservable call - #120
Closed
saurabh12nxf wants to merge 1 commit into
Closed
fix: remove @ts-ignore from OAuth Store makeAutoObservable call#120saurabh12nxf wants to merge 1 commit into
saurabh12nxf wants to merge 1 commit into
Conversation
Signed-off-by: Saurabh Singh <sureshsingh09120@gmail.com>
Contributor
Author
|
Hi @AlexanderShenshin and @tajang97 please take a look and if any changes are required tell me i am happy to fix it |
Contributor
Author
|
Hi @AlexanderShenshin @tajang97, The CI failure appears to be unrelated to my changes - it's a build failure in the @sphereon/pex dependency during yarn install. My changes only touch the OAuthStore.ts file to remove @ts-ignore and improve type safety. Could you please retrigger the CI or let me know if this is a known issue? The specific error is: Thanks! |
AlexanderShenshin
requested changes
Jul 22, 2026
AlexanderShenshin
left a comment
Contributor
There was a problem hiding this comment.
Hi @saurabh12nxf,
It looks like we have actual behavior changes here and _config does become observable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Remove @ts-ignore suppression from OAuth Store and use proper MobX 6 type-safe approach.
Notes for reviewer:
Checklist
Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)