Skip to content

fix: remove @ts-ignore from OAuth Store makeAutoObservable call - #120

Closed
saurabh12nxf wants to merge 1 commit into
hiero-ledger:mainfrom
saurabh12nxf:fix/oauth-store-type-safety-clean
Closed

fix: remove @ts-ignore from OAuth Store makeAutoObservable call#120
saurabh12nxf wants to merge 1 commit into
hiero-ledger:mainfrom
saurabh12nxf:fix/oauth-store-type-safety-clean

Conversation

@saurabh12nxf

Copy link
Copy Markdown
Contributor

Description:
Remove @ts-ignore suppression from OAuth Store and use proper MobX 6 type-safe approach.

  • Replace @ts-ignore with proper MobX annotations
  • Remove TODO comment about type safety issue
  • Use empty annotations object with autoBind option
  • Related issue(s): Fixes type safety issue in OAuthStore.ts lines 35-38

Notes for reviewer:

  • TypeScript compilation now passes without errors
  • All 16 OAuth Store tests continue to pass
  • No functional changes, only improved type safety

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Saurabh Singh <sureshsingh09120@gmail.com>
@saurabh12nxf

Copy link
Copy Markdown
Contributor Author

Hi @AlexanderShenshin and @tajang97 please take a look and if any changes are required tell me i am happy to fix it

@saurabh12nxf

Copy link
Copy Markdown
Contributor Author

Hi @AlexanderShenshin @tajang97,

The CI failure appears to be unrelated to my changes - it's a build failure in the @sphereon/pex dependency during yarn install. My changes only touch the OAuthStore.ts file to remove @ts-ignore and improve type safety.

Could you please retrigger the CI or let me know if this is a known issue?

The specific error is:
@sphereon/pex@npm:5.0.0-unstable.24 couldn't be built successfully (exit code 126)

Thanks!

@AlexanderShenshin AlexanderShenshin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saurabh12nxf,

It looks like we have actual behavior changes here and _config does become observable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants