chore: Deprecate GetAccountBalance query - #26466
Conversation
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #26466 +/- ##
============================================
+ Coverage 70.54% 70.56% +0.01%
- Complexity 11692 11693 +1
============================================
Files 2586 2586
Lines 108553 108553
Branches 12166 12165 -1
============================================
+ Hits 76584 76605 +21
+ Misses 27971 27954 -17
+ Partials 3998 3994 -4
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Node: HAPI Test (Atomic Batch) Results 167 files ±0 1 errors 166 suites - 1 2h 32m 9s ⏱️ + 8m 1s For more details on these parsing errors, see this check. Results for commit 30fad75. ± Comparison against base commit d3e580c. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
jsync-swirlds
left a comment
There was a problem hiding this comment.
Proto changes look good.
Very happy to finally see this deprecated.
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech> # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/crypto/HapiGetAccountBalance.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/BalanceSnapshot.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/CryptoGetInfoRegression.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/queries/DisabledNodeOperatorTest.java
✅ All tests passed ✅🏷️ Commit: e7291d3 Learn more about TestLens at testlens.app/docs. |
Deprecates the
CryptoGetAccountBalancequery. Marks the protobuf messages, RPC, and handler as deprecated with mirror-node migration guidance, and removes the query from genesis and test throttle definitions.The test-client/yahcli switch from
CryptoGetAccountBalancetoCryptoGetInfolanded separately in #26740.