Skip to content

chore: Deprecate GetAccountBalance query - #26466

Open
ibankov wants to merge 11 commits into
mainfrom
remove-balance-query
Open

chore: Deprecate GetAccountBalance query#26466
ibankov wants to merge 11 commits into
mainfrom
remove-balance-query

Conversation

@ibankov

@ibankov ibankov commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Deprecates the CryptoGetAccountBalance query. Marks the protobuf messages, RPC, and handler as deprecated with mirror-node migration guidance, and removes the query from genesis and test throttle definitions.

The test-client/yahcli switch from CryptoGetAccountBalance to CryptoGetInfo landed separately in #26740.

ibankov added 2 commits July 21, 2026 16:25
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
@trunk-io

trunk-io Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@lfdt-bot

lfdt-bot commented Jul 21, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ibankov ibankov linked an issue Jul 21, 2026 that may be closed by this pull request
15 tasks
@ibankov ibankov self-assigned this Jul 21, 2026
@ibankov ibankov modified the milestones: v0.77, v0.78 Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #26466      +/-   ##
============================================
+ Coverage     70.54%   70.56%   +0.01%     
- Complexity    11692    11693       +1     
============================================
  Files          2586     2586              
  Lines        108553   108553              
  Branches      12166    12165       -1     
============================================
+ Hits          76584    76605      +21     
+ Misses        27971    27954      -17     
+ Partials       3998     3994       -4     
Files with missing lines Coverage Δ Complexity Δ
...s/sysfiles/validation/ExpectedCustomThrottles.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../impl/handlers/CryptoGetAccountBalanceHandler.java 89.87% <ø> (ø) 17.00 <0.00> (ø)

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ibankov added 4 commits July 22, 2026 10:13
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
@ibankov ibankov changed the title chore: Switch to GetAccountDetails in test-clients/yahcli chore: Deprecate GetAccountBalance query Jul 22, 2026
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Node: HAPI Test (Atomic Batch) Results

  167 files  ±0      1 errors  166 suites   - 1   2h 32m 9s ⏱️ + 8m 1s
  293 tests  - 1    292 ✅  - 1  1 💤 ±0  0 ❌ ±0 
1 655 runs   - 1  1 654 ✅  - 1  1 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 30fad75. ± Comparison against base commit d3e580c.

This pull request removes 1 test.
com.hedera.services.bdd.suites.validation.ConcurrentSubprocessValidationTest ‑ as written

♻️ This comment has been updated with latest results.

@ibankov
ibankov marked this pull request as ready for review July 22, 2026 09:48
@ibankov
ibankov requested review from a team and jsync-swirlds as code owners July 22, 2026 09:48
@ibankov
ibankov requested a review from xin-hedera July 22, 2026 09:48
Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>

@jsync-swirlds jsync-swirlds left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto changes look good.

Very happy to finally see this deprecated.

Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/crypto/HapiGetAccountBalance.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/BalanceSnapshot.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/CryptoGetInfoRegression.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/queries/DisabledNodeOperatorTest.java
@testlens-app

testlens-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: e7291d3
▶️ Tests: 54831 executed
⚪️ Checks: 108/108 completed


Learn more about TestLens at testlens.app/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the usage of GetAccountBalance query in test-clients/yahcli

3 participants