Skip to content

chore: add github actions (#3) - #10

Merged
jasuwienas merged 7 commits into
mainfrom
3-github-actions
Jan 30, 2026
Merged

chore: add github actions (#3)#10
jasuwienas merged 7 commits into
mainfrom
3-github-actions

Conversation

@jasuwienas

@jasuwienas jasuwienas commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Description:

Add github acitons

Note for reviewers: this PR contains mainly code moved from smart-contracts repository. In order to have a look at actually changed logic review: #13 first

Related issue(s):

Fixes #3

Merge tests first or there will be nothing to run in this github actions :X .

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas
jasuwienas requested review from a team as code owners December 31, 2025 12:22
@jasuwienas jasuwienas self-assigned this Dec 31, 2025
@jasuwienas jasuwienas added the github_actions Pull requests that update Github Actions code. label Dec 31, 2025
Ferparishuertas
Ferparishuertas previously approved these changes Jan 2, 2026

@Ferparishuertas Ferparishuertas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@natanasow
natanasow changed the base branch from main to 2-tests January 7, 2026 12:58
@natanasow
natanasow changed the base branch from 2-tests to main January 7, 2026 12:58
simzzz
simzzz previously approved these changes Jan 7, 2026
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@github-actions

github-actions Bot commented Jan 14, 2026

Copy link
Copy Markdown

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3465af3.

♻️ This comment has been updated with latest results.

Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
@jasuwienas
jasuwienas marked this pull request as draft January 20, 2026 14:23
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas jasuwienas changed the title chore: triggering github actions (#3) chore: add github actions (#3) Jan 22, 2026
@jasuwienas

Copy link
Copy Markdown
Contributor Author

I’m still not happy with how the pipelines are working. On almost every workflow run, a few actions end up getting canceled due to timeouts... The Hedera local node is significantly faster, more reliable, and appears to be much more stable.

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas
jasuwienas marked this pull request as ready for review January 26, 2026 14:39

@quiet-node quiet-node left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/relay-values.yml
@quiet-node

Copy link
Copy Markdown

Also, should we have an extra workflow to check for code quality and compilation warnings? We could use tools like eslint or tsc --noemit, or similar options for Solidity. This would help us maintain clean code for every PR coming in. Of course, this can be a new ticket, not in this PR

@jasuwienas

jasuwienas commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

Also, should we have an extra workflow to check for code quality and compilation warnings? We could use tools like eslint or tsc --noemit, or similar options for Solidity. This would help us maintain clean code for every PR coming in. Of course, this can be a new ticket, not in this PR

Yes, we definitely should do that. Issue for that: #24

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

@quiet-node quiet-node left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work!

@jasuwienas
jasuwienas merged commit 1c3e739 into main Jan 30, 2026
9 of 36 checks passed
jasuwienas added a commit that referenced this pull request Jan 30, 2026
* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* feat: making gh actions work correctly with solo

Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>

* feat: make solo work in pipelines (#2)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* feat: fining gh action (#2)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: set proper dispatch conditions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

---------

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
jasuwienas added a commit that referenced this pull request Jan 30, 2026
* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: triggering github actions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* feat: making gh actions work correctly with solo

Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>

* feat: make solo work in pipelines (#2)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* feat: fining gh action (#2)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

* chore: set proper dispatch conditions (#3)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>

---------

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github Actions code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants