Skip to content

fix: convert HRC-904 example doc tags from // to /// for NatSpec - #132

Merged
natanasow merged 4 commits into
hiero-ledger:mainfrom
ValentinVPK:127-hrc904-natspec-comment-tags
Aug 20, 2026
Merged

fix: convert HRC-904 example doc tags from // to /// for NatSpec#132
natanasow merged 4 commits into
hiero-ledger:mainfrom
ValentinVPK:127-hrc904-natspec-comment-tags

Conversation

@ValentinVPK

Copy link
Copy Markdown
Contributor

Description:

Convert the HRC-904 example doc tags from // to /// so solc parses them as NatSpec. The tags were complete but written with two slashes, so none of the docs reached userdoc/devdoc, explorers, or IDE hovers.

  • Convert // doc-comment lines (@tag lines and their free-text continuations) to /// in Airdrop, CancelAirdrop, ClaimAirdrop, and TokenReject
  • Leave // SPDX-License-Identifier lines untouched

Related issue(s):

Fixes #127

Notes for reviewer:

Docs-only change — no runtime/ABI impact. Diff is a pure ///// swap (146 insertions / 146 deletions). Verified with npx hardhat compile: solc now emits userdoc/devdoc for all four contracts (e.g. TokenReject → contract @notice + 4 documented methods + 13 @param entries), whereas before they were empty.

Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech>
@ValentinVPK
ValentinVPK requested review from a team as code owners July 31, 2026 06:56
@ValentinVPK
ValentinVPK requested a review from nathanklick July 31, 2026 06:56
@ValentinVPK ValentinVPK self-assigned this Jul 31, 2026
@ValentinVPK ValentinVPK added the enhancement New feature or request label Jul 31, 2026
@ValentinVPK ValentinVPK added this to the 0.2.0 milestone Jul 31, 2026
@natanasow
natanasow merged commit 28aeb8e into hiero-ledger:main Aug 20, 2026
23 checks passed
@swirlds-automation

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HRC-904 example docs use // comment tags, which solc does not parse as NatSpec

3 participants