fix: correct FeeHelper.createFixedFeesForToken to store both fees - #133
Merged
natanasow merged 3 commits intoAug 20, 2026
Merged
Conversation
Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech>
natanasow
approved these changes
Aug 18, 2026
Contributor
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix
FeeHelper.createFixedFeesForToken, which allocated a 1-element array and wrote both fees to index[0], silently discarding the first fee. A token created with it would charge only the second collector.[1]instead of overwriting[0]token-serviceandtoken-service-v2Related issue(s):
Fixes #122
Notes for reviewer:
Bug-fix only — no signature change. Verified with
npx hardhat compile(clean). The function is an unusedinternalhelper (no callers incontracts/ortest/), so no acceptance tests exercise it and none regress; thefixedFeesreferences in the test suite are independent JS-side fixtures. The issue's step 2 (an N-fee builder) was intentionally dropped — an N-of-identical-fees helper has no real use case, mirrors an already-unused sibling, and would be scope creep on a bug fix.