feat: change visibility of transferFrom, transferFromNFT, redirectForToken and updateNFTsMetadata - #139
Merged
Merged
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
changed the title
transferFrom, transferFromNFT, redirectForToken and updateNFTsMetadata
Member
Author
|
|
ValentinVPK
approved these changes
Aug 18, 2026
natanasow
force-pushed
the
138-change-visibility-of-some-methods
branch
from
August 19, 2026 08:12
2a403f1 to
a8c1399
Compare
# Conflicts: # contracts/token-service-v2/HederaTokenService.sol # contracts/token-service/HederaTokenService.sol
# Conflicts: # contracts/token-service-v2/HederaTokenService.sol # contracts/token-service/AtomicHTS.sol # contracts/token-service/HederaTokenService.sol
Contributor
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change visibility of
transferFrom(L289),transferFromNFT(L304),redirectForToken(L677) to internal inHederaTokenService..solSolution:
Changes the visibility of three helpers in HederaTokenService from external to internal:
Updates the in-repo call sites that invoked them via this. (external self-call),
which will not compile once the functions are internal:
Notes
internal call syntax.
needed for it.
fix also targets v2, that file needs the same visibility change in the same PR.
Two possible scope additions:
Related issue(s):
Fixes #138
Notes for reviewer:
Checklist