Skip to content

extra for transfer list length - #1321

Closed
littletarzan wants to merge 1 commit into
hiero-ledger:mainfrom
littletarzan:len-extra
Closed

extra for transfer list length#1321
littletarzan wants to merge 1 commit into
hiero-ledger:mainfrom
littletarzan:len-extra

Conversation

@littletarzan

Copy link
Copy Markdown
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: littletarzan <mdelore.ufl@gmail.com>
@littletarzan
littletarzan requested a review from a team as a code owner October 31, 2025 16:42

@Reccetech Reccetech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@littletarzan . Thanks for this PR.
I wanted to get more background on the suggested addition of "ExtendedAssetChanges" as an additional extra. From my understanding this would allow >10 accounts in a CryptoTransfer.

  1. Is the 10 limit in Cryptotransfers something you have experienced as a problem?
  2. Would there be an upper boundary on how many accounts you could include?
  3. How would we charge for this as an extra? i.e. each account >10 in the CryptoTransfer is a given amount?
    @joshmarinacci

@littletarzan

Copy link
Copy Markdown
Contributor Author

@littletarzan . Thanks for this PR. I wanted to get more background on the suggested addition of "ExtendedAssetChanges" as an additional extra. From my understanding this would allow >10 accounts in a CryptoTransfer.

  1. Is the 10 limit in Cryptotransfers something you have experienced as a problem?
  2. Would there be an upper boundary on how many accounts you could include?
  3. How would we charge for this as an extra? i.e. each account >10 in the CryptoTransfer is a given amount?
    @joshmarinacci

Hello @Reccetech

  1. Yes, lambdaplex.io's onchain fill-or-kill for a large market order in a deep book needs the option to settle with a large number of counterparties.
  2. Yes, max HAPI tx size of 6kb is a natural upper bound; when most parties' authorization comes from a hook call with 32 bytes calldata, this will work out to a limit of ~100 total asset changes
  3. Exactly, each asset change past 10 is an extra at the higher ExtendedAssetChanges price

@Reccetech

Copy link
Copy Markdown
Contributor

Thanks @littletarzan . I certainly understand the need.
With HIP-1261 we made an effort to just convert existing functionality and pricing to the new pricing architecture. We did not add any new functionality.
So can I suggest that we separate out your idea with new functionality into a new HIP that we can run through the approval process for discussion.
Feedback appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants