Fix YAML syntax error and security issue in stale-hip-management workflow - #1322
Merged
Conversation
RaphaelMessian
approved these changes
Nov 3, 2025
…flow - Fix YAML syntax error on line 94 by using heredoc for multi-line comment - Add input validation to prevent code injection attacks - Move workflow inputs to environment variables with validation - Replace backtick quotes with single quotes for better YAML compatibility Signed-off-by: Michael Garber <michael.garber@hashgraph.com>
mgarbs
force-pushed
the
fix-workflow-syntax-and-security
branch
from
November 3, 2025 13:34
0434c85 to
5042a4c
Compare
RaphaelMessian
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical YAML syntax error and security vulnerability in the stale-hip-management workflow:
gh pr commentcommand was causing a parsing error. Resolved by using a heredoc pattern instead of inline multi-line stringsgithub.event.inputs.*) were being used directly in bash without validation, allowing potential code injection. Now validates that inputs are positive integers before useChanges
Test Plan
Security Impact
This PR addresses a code injection vulnerability where malicious workflow_dispatch inputs could execute arbitrary code. The fix ensures only numeric values are accepted for the day parameters.