Update HIP-1137 based on implementation feedback - #1419
Merged
Conversation
* Modified the NodeUpdateTransactionBody to use a wrapper message for the associated registered nodes. * This enables differentiating an empty list from an _unset_ list. * Clarified that `RegisteredNodeDelete` will fail if that `RegisteredNode` is present in the `associated_registered_nodes` list for any Consensus `Node`. * Added support for a `GeneralServiceEndpoint` endpoint type in `RegisteredServiceEndpoint` so that node operators can declare additional services for their nodes. Signed-off-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
force-pushed
the
hip-1137-add-endpoint-type
branch
from
March 6, 2026 00:02
3000cfc to
0601d2b
Compare
mgarbs
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RegisteredNodeDeletewill fail if thatRegisteredNodeis present in theassociated_registered_nodeslist for any ConsensusNode.GeneralServiceEndpointendpoint type inRegisteredServiceEndpointso that node operators can declare additional services for their nodes.