fix: correct deploy-pages SHA and set VITE_BASE for GitHub Pages - #1430
Merged
Conversation
The deploy job was failing because the pinned SHA for actions/deploy-pages was incorrect (d6db9...603fc vs the actual v4.0.5 SHA d6db9...0c03e), causing a 404 when the runner tried to download the action. Additionally, move the configure-pages step before the build so its base_path output can be passed as VITE_BASE to Vite. Without this, all asset paths resolve against "/" instead of "/hiero-improvement-proposals/", breaking CSS, JS, and images on the deployed site. Signed-off-by: Michael Garber <michael.garber@hashgraph.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RaphaelMessian
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/deploy-pagesSHA — the pinned commit hashd6db9...603fcdoes not exist (404), causing the deploy job to fail at "Set up job". The correct SHA for v4.0.5 isd6db9...0c03e.configure-pagesstep before the Vite build and pass itsbase_pathoutput asVITE_BASEso asset paths resolve correctly under/hiero-improvement-proposals/on GitHub Pages.Root Cause
The deploy workflow was introduced in #1423 with a subtly corrupted SHA for
actions/deploy-pages— the two hashes differ by only a few hex characters near the end. The build job has always succeeded, but the deploy job has never completed.Additionally, without
VITE_BASEset, even a successful deploy would serve a broken site — all CSS, JS, and images would 404 because Vite would emit paths relative to/instead of/hiero-improvement-proposals/.What Changed
actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac2b3c603fc(does not exist)actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e(v4.0.5)configure-pagesran aftervite buildconfigure-pagesruns beforevite build, output feedsVITE_BASERecommendation
After merging, switch the GitHub Pages source in Settings → Pages → Build and deployment → Source from "Deploy from a branch" to "GitHub Actions". The current legacy (Jekyll) setting triggers a separate build that always fails.
Test plan
🤖 Generated with Claude Code