Skip to content

Replace spring jpa with spring relational#13481

Draft
sdimitrov9 wants to merge 19 commits into
mainfrom
Replace-spring-jpa-with-spring-relational
Draft

Replace spring jpa with spring relational#13481
sdimitrov9 wants to merge 19 commits into
mainfrom
Replace-spring-jpa-with-spring-relational

Conversation

@sdimitrov9

@sdimitrov9 sdimitrov9 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description:
Replace spring jpa with spring relational across modules, in rest-java, grpc, importer and common modules.

Related issue(s):

Fixes #13042

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 self-assigned this May 4, 2026
@sdimitrov9 sdimitrov9 added enhancement Type: New feature performance rest-java Area: Java REST API labels May 4, 2026
@lfdt-bot

lfdt-bot commented May 4, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production

codacy-production Bot commented May 4, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 3 high · 28 medium · 69 minor

Alerts:
⚠ 100 issues (≤ 0 issues of at least minor severity)

Results:
100 new issues

Category Results
BestPractice 19 medium
2 minor
Documentation 12 minor
ErrorProne 3 high
CodeStyle 55 minor
Complexity 9 medium

View in Codacy

🟢 Metrics 835 complexity

Metric Results
Complexity 835

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from c4f5bb6 to fcfdaf1 Compare May 5, 2026 06:45
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from fcfdaf1 to 3435ec6 Compare May 5, 2026 07:02
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch 3 times, most recently from 0226caf to 464bbbd Compare May 5, 2026 12:15
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from 464bbbd to 2116f09 Compare May 5, 2026 13:47
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 added the grpc Area: GRPC API label May 8, 2026
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 added importer Area: Importer labels May 11, 2026
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from 1ca13a0 to ce8d3a1 Compare May 11, 2026 10:04
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from c09d093 to c7bf87d Compare May 12, 2026 06:57
@jnels124

Copy link
Copy Markdown
Contributor

I havent fully looked into why the hibernate validator is still present but if it is needed still, we need to be sure to update the RuntimeHintsConfiguration.java for at least rest java (and probably web3) to include additional hints.

registerReflectionTypes(hints, CONSTRUCTORS_ONLY, Log_$logger.class); needs to become registerReflectionTypes(hints, CONSTRUCTORS_ONLY, Log_$logger.class, Messages_$bundle.class);

@sdimitrov9

sdimitrov9 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

I havent fully looked into why the hibernate validator is still present but if it is needed still, we need to be sure to update the RuntimeHintsConfiguration.java for at least rest java (and probably web3) to include additional hints.

registerReflectionTypes(hints, CONSTRUCTORS_ONLY, Log_$logger.class); needs to become registerReflectionTypes(hints, CONSTRUCTORS_ONLY, Log_$logger.class, Messages_$bundle.class);

RuntimeHintsConfiguration is updated as requested.
Otherwise all annotations that are coming from the jakarta.validation-api , like Min,Max,Size,Valid, etc. are implemented by the hibernate validator. We can probably get rid of it by providing our implementation, but it isn't worth it considering the space we are going to save is quite small (hibernate-validator-9.0.1.Final.jar is 1.3 MB).

Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
@sdimitrov9 sdimitrov9 force-pushed the Replace-spring-jpa-with-spring-relational branch from 26a1d1f to 568cc6a Compare May 27, 2026 08:15
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature grpc Area: GRPC API importer Area: Importer performance rest-java Area: Java REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POC using spring data relational instead of jpa

3 participants