Skip to content

refactor: use slices.Contains to simplify code - #1442

Merged
0xivanov merged 1 commit into
hiero-ledger:mainfrom
geekvest:main
Jul 22, 2025
Merged

refactor: use slices.Contains to simplify code#1442
0xivanov merged 1 commit into
hiero-ledger:mainfrom
geekvest:main

Conversation

@geekvest

Copy link
Copy Markdown
Contributor

Description:

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@geekvest
geekvest requested review from a team as code owners July 15, 2025 06:38
@geekvest
geekvest requested a review from 0xivanov July 15, 2025 06:38
@lfdt-bot

lfdt-bot commented Jul 15, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov

codecov Bot commented Jul 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
sdk/batch_transaction.go 81.48% <100.00%> (-0.17%) ⬇️

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xivanov 0xivanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @geekvest

@0xivanov

Copy link
Copy Markdown
Contributor

@geekvest the commit signatures are not verified and i cannot merge the PR if that's the case

Signed-off-by: geekvest <cuimoman@sohu.com>
@geekvest

Copy link
Copy Markdown
Contributor Author

@geekvest the commit signatures are not verified and i cannot merge the PR if that's the case

Thanks for you notice. Signed. Please review again. 😄

@0xivanov
0xivanov merged commit 87a5cac into hiero-ledger:main Jul 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants