Skip to content

feat: Add customFeeLimits for Scheduled Transactions - #1455

Merged
0xivanov merged 5 commits into
mainfrom
custom-fee-limit-for-scheduled-transactions
Aug 29, 2025
Merged

feat: Add customFeeLimits for Scheduled Transactions#1455
0xivanov merged 5 commits into
mainfrom
custom-fee-limit-for-scheduled-transactions

Conversation

@0xivanov

@0xivanov 0xivanov commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Description:

Adds customFeeLimits for Scheduled Transactions (currently only for TopicSubmitTransaction)

Related issue(s):

Fixes #1449

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Jul 28, 2025
@lfdt-bot

lfdt-bot commented Jul 28, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
sdk/topic_message_submit_transaction.go 87.14% <100.00%> (+0.31%) ⬆️
sdk/transaction.go 69.21% <100.00%> (+0.30%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
0xivanov marked this pull request as ready for review August 18, 2025 05:58
@0xivanov
0xivanov requested review from a team as code owners August 18, 2025 05:58
@0xivanov
0xivanov requested a review from gsstoykov August 18, 2025 05:58
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
0xivanov requested a review from a team as a code owner August 18, 2025 06:52
@0xivanov
0xivanov requested a review from andrewb1269 August 18, 2025 06:52
0xivanov and others added 2 commits August 26, 2025 10:28
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
update hiero mirror node and consensus node versions

Signed-off-by: SimiHunjan <simi.hunjan.k@gmail.com>

@gsstoykov gsstoykov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov
0xivanov merged commit 3868bce into main Aug 29, 2025
12 of 13 checks passed
@0xivanov
0xivanov deleted the custom-fee-limit-for-scheduled-transactions branch August 29, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add customFeeLimits for Scheduled Transactions

4 participants